mirrors/arti.git/crates/tor-cell/src, branch arti-v1.3.0

hs-pow: Clarify a confusing comment in ProofOfWorkV1.

2024-10-09T16:05:21Z

Co-authored-by: Micah Elizabeth Scott

hs-pow: Rename seed to seed_head.

2024-10-09T16:05:21Z

Feedback from the hs-pow code review, the internal seed heading member should be seed_head instead of seed, for consistency. Very low impact change since the field name is not public.

hs-pow: Refactor to prefer stub types rather than cfg sprawl.

2024-10-09T16:05:15Z

In this design, the thin multiplexing layer between PoW types is always available when onion services are in use, but the specific pow schemes (and their dependency libraries) are gated by crate features everywhere. There are now no new cfg() gates. When the pow-v1 scheme is disabled, we can parse `pow-params v1` lines into an empty type (so clients know a PoW scheme exists that might be supported if they were configured differently). We currently don't save the contents of unknown hsdesc items. On the relaycell side, the hs ext module already sets a strong precedent for keeping unrecognized data as a byte vec, and it doesn't provide a good way to signal soft parse errors like unrecognized optional extensions. There, the `v1` type is completely optional, and services lacking a pow scheme suggested by a client would see one of these 'unrecognized' blobs. This isn't necessarily helpful but it fits the rest of the design. Co-authored-by: Micah Elizabeth Scott

tor-hspow: Big refactor, dissolve this crate

2024-10-09T16:04:35Z

My previous strategy here was to try and centralize hspow in one crate, writing it like a self-contained feature. That introduced friction in the data types, prompting the use of simplistic types at the netdoc/cell layers and full-featured types in the optional modules. This changes tactics, dissolving the low-level parts of tor-hspow into tor-hscrypto and the high-level parts into hsclient/hsservice. Full featured types are used everywhere now, but the tradeoff is that compile-time configurability is a lot more pervasive. Anything that knows about PoW types at all needs to be fully configured out. I took this opportunity to try a more complete set of crate features, allowing users to configure individual PoW schemes. Co-authored-by: Micah Elizabeth Scott

tor-cell: Support encoding proofs-of-work in intro_payload

2024-10-09T16:04:35Z

Like parameters, PoW solutions are versioned to account for multiple algorithms over time. A single solution of a specific version may accompany an INTRO1/2 as part of the encrypted extensions section. Its encoding may depend on the version. Co-authored-by: Micah Elizabeth Scott

tor-memquota: Explain choice of bounds

2024-10-02T18:11:30Z

Properted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2459#note_3086841

Revert "tor-cell: Use HasMemoryCostStructural, rather than Copy"

2024-10-02T18:11:30Z

This reverts commit def8810156f8c2bf8f18ef9ad75a61601f6fea78.

tor-cell: Use HasMemoryCostStructural, rather than Copy

2024-10-02T18:11:26Z

As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2459#note_3086839

Some HasMemoryCost impls in tor-cell

2024-10-02T18:11:26Z

tor-bytes: Only report Truncated for errors at the outer level

2024-09-11T13:19:19Z

This is item 1 from https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074562 and the alternative to item 2 presented in the 2nd half of https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074648 (Item 3 was done earlier, but now we change the behaviour.) Fixes #1614.