mirrors/arti.git/crates/tor-cell/src, branch arti-v0.0.3 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.3 2021-12-28T20:15:40Z extend lints to include 'clippy::all' 2021-12-28T20:15:40Z Daniel Eades danieleades@hotmail.com 2021-12-28T20:15:40Z urn:sha1:592642a9e6c1c03e525f8b452f4b97e6fd17ff9b tor-cell: replace an XXXX with a TODO. 2021-12-16T15:29:30Z Nick Mathewson nickm@torproject.org 2021-12-16T15:29:30Z urn:sha1:de45ee41a426d0952db571fe4365b1512c8822ed The original comment was a gnomic question about what to box; the real issue is that we want to avoid copying data in our critical path. Extend trace messages for destroy/truncated reasons. 2021-12-15T16:33:48Z Nick Mathewson nickm@torproject.org 2021-12-15T16:33:48Z urn:sha1:f73840544cdd79ce839b5ae0958d85db45f9b1ce It makes sense to put the method for human-readable strings onto the type itself, so that we can format these whenever they occur. I'm choosing the "human_str" method name here, since caret-generated types already have a to_str. I was thinking about using Display, but caret types already implement that. I've also moved the message from "warn!" to "debug!", since these aren't necessarily a problem condition. Merge remote-tracking branch 'origin/mr/191' 2021-12-15T15:46:58Z Nick Mathewson nickm@torproject.org 2021-12-15T15:46:58Z urn:sha1:1cf0b87eb75d45ba36b8b7c5619c13b7ae97e487 Methodize the destroy circuit reason 2021-12-14T22:26:45Z Neel Chauhan neel@neelc.org 2021-12-14T22:26:45Z urn:sha1:b601d8b1476810e33550b2f007fe91396ed47ba8 Actually decrement the stream-level SENDME window 2021-12-14T16:37:56Z eta tor@eta.st 2021-12-14T15:49:40Z urn:sha1:8d660cbcf1a655769425dd0a303e5446f6cb8542 arti!126 overhauled the `tor-proto` circuit reactor, but left out one very important thing: actually decrementing the SENDME window for streams (not circuits) when we send cells along them. Since the circuit-level SENDME window would often prevent us from running into a problem, this wasn't caught until my benchmarking efforts noticed it (in the form of Tor nodes aborting the circuit for a protocol violation). fixes arti#260 s/hidden/onion/g in code comments 2021-12-13T21:18:53Z Neel Chauhan neel@neelc.org 2021-12-13T21:18:53Z urn:sha1:d621166c80331fd6d8ccd7ad7e27420c4da4c0d8 Log on TRUNCATED cell 2021-12-13T20:21:19Z Neel Chauhan neel@neelc.org 2021-12-13T20:11:55Z urn:sha1:b6ef6593119f056f430e7b2b0a01affe1cd64eb5 Treat unrecognized SENDME versions as an error. 2021-12-08T18:03:20Z Nick Mathewson nickm@torproject.org 2021-12-08T17:59:06Z urn:sha1:a49c1c1f1ea00dd22a134822cf069e8342a991a8 We should never get one of these unless we have opted in to get it. (This behavior is the same as C tor.) Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231.