mirrors/arti.git/crates/tor-cell/src/relaycell/msg.rs, branch arti-v1.2.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.42024-02-13T14:37:11Ztor_cell: never construct empty DATA messages.2024-02-13T14:37:11ZNick Mathewsonnickm@torproject.org2024-02-13T14:37:11Zurn:sha1:b5c70dad02124549a13e25f62c8073fef4a063fe
We never actually constructed these before, but now we enforce it at
the API level.
Part of #1269.
tor_cell: Reject empty DATA messages2024-02-13T14:23:04ZNick Mathewsonnickm@torproject.org2024-02-13T14:23:04Zurn:sha1:dbe8623356b673cfe716e00fef654ca8bf8a1153
If we don't reject these, they are a way to inject an undetected
traffic signal. (This is LOW severity, since we only accept DATA
when a stream is open, since DATA messages are rate-limited,
and since using length==1 is nearly as effective.)
Closes #1269.
This is TROVE-2024-001.
educe: Use std's default for enums where default variant is unit2024-02-12T11:38:36ZIan Jacksonijackson@chiark.greenend.org.uk2024-02-12T11:07:42Zurn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a
Since Rust 1.66, std's default works properly for enums, provided that
the default variant is a unit.
Review all uses of `#[educe(default)]` on enums and replace them with
std where possible, which is most of them.
In 1.66 and later, std's `#[derive(Default)]` doesn't infer any
generic bounds on the derived impl, where it's an enum - since the
unit variant can always be constructed. So this change doesn't add
any generic bounds and is not API-visible.
Use HandshakeType in Extend2 and CircuitExtender::begin2023-11-27T16:48:03ZJim Newsomejnewsome@torproject.org2023-11-16T17:23:05Zurn:sha1:5d7f70c0fe515aee8640f336cc799b70828fd109tor-cell: Add accessors for Begin.2023-09-27T17:42:50ZNick Mathewsonnickm@torproject.org2023-09-26T20:14:33Zurn:sha1:082716731031e54f36092be32b7e046c4bc9e2a3proto: Convert MsgHandler API to expect a message, not a cell.2023-06-12T18:55:26ZNick Mathewsonnickm@torproject.org2023-06-12T18:55:26Zurn:sha1:beecf3c92c95fd1e0fdddfcc32703abd4cdeadfc
Closes #887.
Change CircTarget::linkspecs() to return an encoded list.2023-05-10T16:30:32ZNick Mathewsonnickm@torproject.org2023-05-10T16:25:57Zurn:sha1:7ce808b75bb500f27ce7837d4f76cbf7fc1ee705
If we didn't do this, we would need to transfrom
`EncodedLinkSpec`s into a `LinkSpec::Unrecognized`, which is not
semantically right. What's more, every user of this API wants to
consume encoded link specifiers, so encoding them early saves a
little effort.
Move responsibility for linkspec sorting to CircTarget.2023-05-10T15:00:57ZNick Mathewsonnickm@torproject.org2023-05-09T14:49:15Zurn:sha1:e919ade062b98d4c9567d6cedf723dab60ff207e
This change is necessary so that we can build Extend2 messages
that have their LinkSpecs appear in a verbatim order as provided
in an INTRODUCE2 message or in a HS descriptor.
Upgrade to bitflags 2.02023-03-13T12:47:14ZNick Mathewsonnickm@torproject.org2023-03-13T12:47:14Zurn:sha1:d6bb8fee0b3f010902d8297f16589467d82e4e4f
This version of bitflags now requires us to explicitly list the
traits that we want to derive for our bit-flags structs.
Change several cfgs to refer to new feature names.2023-02-28T16:15:39ZNick Mathewsonnickm@torproject.org2023-02-28T16:14:58Zurn:sha1:09d601d0507eea20221599ab604e5b077ef9259f