mirrors/arti.git/crates/tor-cell/src/chancell, branch arti-v0.1.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.1.0 2022-02-17T18:25:54Z Merge branch 'clippy-followup' into 'main' 2022-02-17T18:25:54Z Nick Mathewson nickm@torproject.org 2022-02-17T18:25:54Z urn:sha1:80be59497ef1a4dc30e69e9c2527418427db41fa Remove some needless refs and slicing See merge request tpo/core/arti!327 Remove some needless refs and slicing 2022-02-17T11:16:27Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-02-17T11:15:32Z urn:sha1:bbcc871105e5c9720752ec39d40502e241e56290 Prompted by nightly's clippy (which has some false positives, so is currently disabled). tor-cell: provide HasKind. 2022-02-15T14:41:10Z Nick Mathewson nickm@torproject.org 2022-02-11T17:17:11Z urn:sha1:da0e9e456c398d33c476db5a28e1c6fff5320c4d Additionally, refactor the IoError out of tor_cell::Error: nothing in TorCell created this; it was only used by tor_proto. This required refactoring in tor_proto to use a new error type. Here I decided to use a new CodecError for now, though we may refactor that away soon too. tor-cell: replace an XXXX with a TODO. 2021-12-16T15:29:30Z Nick Mathewson nickm@torproject.org 2021-12-16T15:29:30Z urn:sha1:de45ee41a426d0952db571fe4365b1512c8822ed The original comment was a gnomic question about what to box; the real issue is that we want to avoid copying data in our critical path. Extend trace messages for destroy/truncated reasons. 2021-12-15T16:33:48Z Nick Mathewson nickm@torproject.org 2021-12-15T16:33:48Z urn:sha1:f73840544cdd79ce839b5ae0958d85db45f9b1ce It makes sense to put the method for human-readable strings onto the type itself, so that we can format these whenever they occur. I'm choosing the "human_str" method name here, since caret-generated types already have a to_str. I was thinking about using Display, but caret types already implement that. I've also moved the message from "warn!" to "debug!", since these aren't necessarily a problem condition. s/hidden/onion/g in code comments 2021-12-13T21:18:53Z Neel Chauhan neel@neelc.org 2021-12-13T21:18:53Z urn:sha1:d621166c80331fd6d8ccd7ad7e27420c4da4c0d8 Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. add semicolons if nothing returned 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d deglob some enums, use concise iteration syntax 2021-11-25T12:39:52Z Daniel Eades danieleades@hotmail.com 2021-11-25T12:39:52Z urn:sha1:052f51ff7115f362c2049c369c4f64864ab3412f enable checked_conversions lint. 2021-10-09T20:53:13Z Nick Mathewson nickm@torproject.org 2021-10-09T20:49:32Z urn:sha1:af7c9d5a0b1bdcfba820160cf89d480efd27760e