mirrors/arti.git/crates/tor-cell/src/chancell/msg.rs, branch arti-v0.0.3 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.3 2021-12-16T15:29:30Z tor-cell: replace an XXXX with a TODO. 2021-12-16T15:29:30Z Nick Mathewson nickm@torproject.org 2021-12-16T15:29:30Z urn:sha1:de45ee41a426d0952db571fe4365b1512c8822ed The original comment was a gnomic question about what to box; the real issue is that we want to avoid copying data in our critical path. Extend trace messages for destroy/truncated reasons. 2021-12-15T16:33:48Z Nick Mathewson nickm@torproject.org 2021-12-15T16:33:48Z urn:sha1:f73840544cdd79ce839b5ae0958d85db45f9b1ce It makes sense to put the method for human-readable strings onto the type itself, so that we can format these whenever they occur. I'm choosing the "human_str" method name here, since caret-generated types already have a to_str. I was thinking about using Display, but caret types already implement that. I've also moved the message from "warn!" to "debug!", since these aren't necessarily a problem condition. s/hidden/onion/g in code comments 2021-12-13T21:18:53Z Neel Chauhan neel@neelc.org 2021-12-13T21:18:53Z urn:sha1:d621166c80331fd6d8ccd7ad7e27420c4da4c0d8 Resolve roughly half of the XXXXs. 2021-12-06T20:11:03Z Nick Mathewson nickm@torproject.org 2021-12-06T20:01:29Z urn:sha1:31b385c5b20205e879a847a9331c30a37dc2e6f5 We want to only use TODO in the codebase for non-blockers, and open tickets for anything that is a bigger blocker than a TODO. These XXXXs seem like definite non-blockers to me. Part of arti#231. add semicolons if nothing returned 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d deglob some enums, use concise iteration syntax 2021-11-25T12:39:52Z Daniel Eades danieleades@hotmail.com 2021-11-25T12:39:52Z urn:sha1:052f51ff7115f362c2049c369c4f64864ab3412f enable checked_conversions lint. 2021-10-09T20:53:13Z Nick Mathewson nickm@torproject.org 2021-10-09T20:49:32Z urn:sha1:af7c9d5a0b1bdcfba820160cf89d480efd27760e Document every macro. 2021-09-07T12:44:47Z Nick Mathewson nickm@torproject.org 2021-09-07T12:44:47Z urn:sha1:bd2c9fd8c139303ff2965843c6e952e6ae152149 (The nightly version of clippy now includes macros for its missing_docs_in_private_items lint.) Move all crates into a `crates` subdirectory. 2021-08-27T13:53:09Z Nick Mathewson nickm@torproject.org 2021-08-27T13:53:09Z urn:sha1:557a0ff40b3731d4690767de27010bbeff08777d This will cause some pain for now, but now is really the best time to do this kind of thing.