mirrors/arti.git/crates/tor-bytes/src/reader.rs, branch arti-v1.1.12

tor-bytes: Remove use of arrayref

2023-05-25T18:48:57Z

Part of #872: Now that const generics are in, we have better ways to express converting slices into array-references.

tor-bytes: defend against misuse of extract_n().

2023-03-06T17:33:10Z

Previously, if somebody wrote this code, an attacker could easily use it to cause an OOM panic: ``` let n = r.take_u64(); let items: Vec = r.extract_n(n as usize)?; ``` The first line of defense here is not to write protocols like that: we don't actually _have_ any 32-bit counters in our protocol AFAICT. The second line of defense is to pre-check `n` for reasonableness before calling `extract_n`. Here we add a third line of defense: whereas previously we would do `Vec::with_capacity(n)` in `extract_n`, we now allocate an initial capacity of `min(n, r.remaining())`. This ensures that the size of the allocation can't exceed the remaining length of the message, which (for our cell types at least) should prevent it from overflowing or running OOM.

tor-bytes: Clarify that Cursor is not a good thing, and could be neater.

2023-03-01T16:21:52Z

clarify results of misusing cursors

2023-03-01T15:57:14Z

tor-bytes: Add cursor functionality to Reader

2023-02-28T16:23:44Z

We'll use this to implement signature and MAC checking for EstablishIntro cells.

tor-bytes: Avoid redundant allocation

2022-10-25T14:24:42Z

See c489e1d9118edd842f80b76a636037524a45ee45

tor-bytes: read_nested_*: rustfmt

2022-06-10T11:30:22Z

I disagree with almost all of these layout decisions...

tor-bytes: read_nested_*: Take a closure

2022-06-10T11:27:00Z

This eliminates the possibility of writing the bug of failing to call `should_be_exhausted`. As per this discussion https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/572#note_2811464 Fixes #498

Fix typos in docs and comments

2022-06-09T16:08:56Z

tor-bytes: Provide nested readers

2022-06-09T16:08:56Z