mirrors/arti.git/crates/tor-bytes/src/err.rs, branch arti-v1.4.3mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.32024-10-01T12:52:38Ztor-bytes: Restore the message for Error::Truncated2024-10-01T12:52:38ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-16T10:22:20Zurn:sha1:33144bb9fb019d1a565b7217ef14c0c569143862
This variant is deprecated but it still ought to have a message so
long as it exists.
tor_bytes: Rename new_truncated_for_test to new_incomplete_for_test2024-09-12T11:48:38ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T15:51:40Zurn:sha1:5314741adecad01014a069c4f0ed5018e0f6c207
No semver implications since this wasn't in the last release.
tor-bytes: Add note about other kinds of invalid message2024-09-11T15:49:11ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T15:10:25Zurn:sha1:468c9b38fa20e85dd9afc043e30b7bae4ea7ff13
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2407#note_3075485
tor-bytes: Add imprecations about Incomplete and MissingData2024-09-11T15:49:11ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T14:55:27Zurn:sha1:b4a9802a059e837b2bdc34dbc2ea1bb3a5997262
Prompted by
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2407#note_3075483
tor-bytes: Do many missed renames of Truncated to Incomplete2024-09-11T15:49:08ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T14:51:43Zurn:sha1:e153ab3cc26d3c3122be3198735fa99c763c406ctor-bytes: Rename Truncated to Incomplete, and restore old Truncated as deprecated2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T12:43:23Zurn:sha1:61953378a87b0573617761b07936c643d891b40a
Incomplete is a better name.
This lets us use Truncated for the old, deprecated, conflation of
"Incomplete" with what is now "MissingData".
tor-bytes: Only report Truncated for errors at the outer level2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T13:13:08Zurn:sha1:1632c48a5a2f5744970b841628261d6062881dee
This is item 1 from
https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074562
and the alternative to item 2 presented in the 2nd half of
https://gitlab.torproject.org/tpo/core/arti/-/issues/1614#note_3074648
(Item 3 was done earlier, but now we change the behaviour.)
Fixes #1614.
tor-bytes: Error: provide and call Error::incomplete_error (tidy)2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T11:38:07Zurn:sha1:8d783fb8547d580585d5c335e49c81bf8c000491
Tidy up an error message. Now this can be on one line with variable
name interpolation.
tor-bytes: Error: provide and call Error::incomplete_error (fmt)2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T13:14:01Zurn:sha1:86b3f8a3c9bbe596d931be819649a875097b6113tor-bytes: Error: provide and call Error::incomplete_error2024-09-11T13:19:19ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-11T11:32:08Zurn:sha1:12c2fbe076cfcff8d734b24d6aef243d09c64d15
We introduce the new constructor and call it at the error generation
sites. But there is still not yet any functional change.
Change the type of Truncated's field to be Sensitive.
The original reason for not doing this no longer applies, since we
don't generally want to open-code construction of this variant.
Conveniently, changing the type means we get to find all the sites
where one *is* constructed and adjust them.
In reader.rs and tor-proto we can just call incomplete_error.
In tor-cell, there's a call site where we previously provided an
underestimate, and where the Reader isn't available. We adjust that
ad-hoc but this is fine because the error variant will
change. (relaycell is using a Reader from from_slice.)