mirrors/arti.git/crates/tor-basic-utils/src, branch arti-v0.4.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-24T23:21:12Z Typo fixes (automated with "typos"). 2022-05-24T23:21:12Z Nick Mathewson nickm@torproject.org 2022-05-24T23:18:28Z urn:sha1:3b837eb7f4e43dd26e41869b32a941b3762a8ee2 Suppress clippy warnings in tor-basic-utils. 2022-05-23T16:55:37Z Nick Mathewson nickm@torproject.org 2022-05-23T16:20:44Z urn:sha1:2f1803f4c6f90c3edcf0289a7494d241d9312f58 These are warnings that we've decided it's okay to suppress elsewhere. prepare_send_from: clippy: Have dprintln explicitly return () 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:46:53Z urn:sha1:86d5768c0541bb4399f8b441b3af369a0c6cf836 prepare_send_from: clippy: Avoid a lint 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:44:55Z urn:sha1:d3f261d5efaa77ee58d54a8e49ac231967e15fe7 I think this is worse code, but it's not *significantly* worse. prepare_send_from: clippy: Add missing docs 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:34:23Z urn:sha1:24dde5ddf1e4892316ba59bfaba691ea1764510d I intend to reintroduce this in its own MR. prepare_send_from: clippy: Replace two unwraps 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:42:54Z urn:sha1:739e5b52b11555e3b8d1561a10e3f08d84feb447 prepare_send_from: Break out get_output! macro 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:39:42Z urn:sha1:94038a92271a2922d80064450b1e487e50e32218 So we can change unwrap to expect, which makes this too long to repeat. prepare_send_from: docs and comments improvements 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T09:22:18Z urn:sha1:9fd0050acf983d0c947ad816c886df4fab58937f Apropos review. prepare_send_from: Add tests 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-18T15:03:13Z urn:sha1:426ff28b73ce2367c5893df026cc678f4abe455c When I added these tests, they didn't find any bugs in my own implementation, but I did find a bug in futures::future::unfold. See the in-code comment. channel: Provide and use Sink::prepare_send_from 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-18T15:02:52Z urn:sha1:793782acc80c05e2d2e125c65721c7a0b967d113 This is a general-purpose implementation of the ad-hoc approach currently taken in (eg) crates/tor-proto/src/channel/reactor.rs, with an API intended to defned against the more obvious mistakes. This allows us to separate the two concerns: the channel reactor can focus on handling channel cells and control messages and is over 2.5x shorter. The complexity of the manual sink implementation, and the machinery needed to avoid having to suspend while holding an item, are dealt with separately. That separate implemenation now has proper documentation. (Tests are in the nest commit to avoid this one being even more unwieldy.) We use `extend` to define this as an extension trait. A competitor is `ext` but in my personal projects I have found `extend` slightly better.