mirrors/arti.git/crates/tor-basic-utils/src/retry.rs, branch arti-v2.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.1 2026-06-09T15:36:01Z maint: Run maint/add_warning to deny string slices 2026-06-09T15:36:01Z Clara Engler cve@cve.cx 2026-06-09T15:36:01Z urn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97 This commit executes maint/add_warning with the just added change to deny string slices except in tests. I recommend auditing this by checking out the previous commit followed by running the script yourself and then verifying that the diff is identical to this commit. This commit makes cargo clippy fail. We will add exceptions in the next commit. Fix name of clippy lint to unchecked_time_subtraction (2) 2025-11-06T11:28:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2025-11-06T11:23:25Z urn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff Run maint/add_warning Use uXX::MAX in place of std::uXX::MAX 2024-04-22T17:00:29Z Nick Mathewson nickm@torproject.org 2024-04-22T17:00:29Z urn:sha1:4a1ad1dc89f6a9f48c84411560c1617d9e487abc The old code produced a warning from clippy nightly; we may as well update to use the new associated consts. (They've been there since Rust 1.4x.) Run maint/add_warning. 2024-03-13T16:30:53Z Nick Mathewson nickm@torproject.org 2024-03-13T16:30:53Z urn:sha1:c0c9bd15d42897825dd0ab3d3b8dd1c17bd6320c Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Merge branch 'clippy-allow' into 'main' 2023-07-11T09:37:42Z Ian Jackson iwj@torproject.org 2023-07-11T09:37:42Z urn:sha1:3acc2af4f3411588f80669ae1980679dd260b119 clippy: Allow some of our existing code patterns See merge request tpo/core/arti!1396 tor-basic-utils: retry: Use and justify gen_range_checked 2023-07-10T15:07:18Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-07T12:43:17Z urn:sha1:36f998b69029612b5cab36c4338b632eb3750ad8 delay_bounds's implementation ensures the postcondition, so the potential p[anic in next_delay_msec cannot happen. Run maint/add_warning to actually apply new lint allows 2023-07-10T12:49:51Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-10T11:19:32Z urn:sha1:473447a82e099fd52a674c28f5bc24b3e05208c0 Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks.