mirrors/arti.git/crates/tor-basic-utils/src/futures.rs, branch tor-dirmgr-v0.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-06-24T13:23:38Z clippy: Consolidate many lints in maint/add_warning 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead. Typo fixes (automated with "typos"). 2022-05-24T23:21:12Z Nick Mathewson nickm@torproject.org 2022-05-24T23:18:28Z urn:sha1:3b837eb7f4e43dd26e41869b32a941b3762a8ee2 Suppress clippy warnings in tor-basic-utils. 2022-05-23T16:55:37Z Nick Mathewson nickm@torproject.org 2022-05-23T16:20:44Z urn:sha1:2f1803f4c6f90c3edcf0289a7494d241d9312f58 These are warnings that we've decided it's okay to suppress elsewhere. prepare_send_from: clippy: Have dprintln explicitly return () 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:46:53Z urn:sha1:86d5768c0541bb4399f8b441b3af369a0c6cf836 prepare_send_from: clippy: Avoid a lint 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:44:55Z urn:sha1:d3f261d5efaa77ee58d54a8e49ac231967e15fe7 I think this is worse code, but it's not *significantly* worse. prepare_send_from: clippy: Add missing docs 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:34:23Z urn:sha1:24dde5ddf1e4892316ba59bfaba691ea1764510d I intend to reintroduce this in its own MR. prepare_send_from: clippy: Replace two unwraps 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:42:54Z urn:sha1:739e5b52b11555e3b8d1561a10e3f08d84feb447 prepare_send_from: Break out get_output! macro 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T15:39:42Z urn:sha1:94038a92271a2922d80064450b1e487e50e32218 So we can change unwrap to expect, which makes this too long to repeat. prepare_send_from: docs and comments improvements 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-20T09:22:18Z urn:sha1:9fd0050acf983d0c947ad816c886df4fab58937f Apropos review. prepare_send_from: Add tests 2022-05-23T10:28:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-18T15:03:13Z urn:sha1:426ff28b73ce2367c5893df026cc678f4abe455c When I added these tests, they didn't find any bugs in my own implementation, but I did find a bug in futures::future::unfold. See the in-code comment.