mirrors/arti.git/crates/tor-basic-utils/src/futures.rs, branch arti-v1.1.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.2 2023-01-27T13:28:02Z Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. tor-basic-utils: DropNotifyWatchSender: use DropNotifyEofSignallable 2022-11-23T17:50:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-14T18:47:14Z urn:sha1:c82cda85d69d13312308f9172faaa6a5b1d69fc2 This will help avoid the programmer making the mistake I made here: https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/852#note_2854029 tor-basic-utils: DropNotifyWatchSender test: introduce I 2022-11-23T17:50:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-11-14T18:44:39Z urn:sha1:63a799a118fe74c74247d470ec9957cc73b32d32 We do want to test this with a non-Option type, but we are going to have to wrap it up. Allow "clippy::single_char_pattern" in tests. 2022-10-12T12:50:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-10-11T13:00:07Z urn:sha1:82ad9eea5f80331d0e26a7d5ccfeed9e58a615fb This lint exists for perf reasons, and this is rarely relevant in tests. Using double quoted str is generally cognitively less burdensome. tor-basic-utils: Add a test for DropNotifyWatchSender 2022-07-19T18:04:34Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-19T18:04:34Z urn:sha1:44402f722e27e3c9e3f616e1d84de4fa35aa8ad4 tor-basic-utils: Add ref to upstream issue re drop 2022-07-19T18:00:23Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-19T18:00:23Z urn:sha1:c7933de0ab32ad9782c87c6247057b4c51cd053b tor-basic-utils: Add comment about lack of race 2022-07-19T16:21:22Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-19T16:21:22Z urn:sha1:bd41e29f3332adca562c3dacb20e050bbf9d9c4f In answer to https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/632#note_2822107 I think this is subtle enough that it deserves a comment. arti-client: Provide DropNotifyWatchSender 2022-07-18T17:13:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-18T16:21:01Z urn:sha1:bc498bc7a082d54a4ee28f3353fd0fc9dac4d46c There are going to be some tasks (well, right away, one task) which will want to go away when the sender is dropped. The docs in postage are silent, but postage::watch::Sender does not have a Drop impl so I don't think we can rely on the Receivers getting None from their Stream impl. So we're going to have the watch send Options, which are None only when the sender is dropped. Provide maybe_send on postage::watch::Sender, via extension trait 2022-07-18T17:13:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-07-18T11:04:49Z urn:sha1:7acdd217507c1020e52d2146a013d0fe4e8f964e We need to replace the AtomicBool for dormant mode with something that can wake up tasks. postage::watch is the right shape. But we want to be able to update it but suppress no-op updates. (There is going to be a call site where no-op updates can occur.) In the absence of a suitable upstream method as requested here https://github.com/austinjones/postage-rs/issues/56 we introduce this facility via an extension trait. clippy: Consolidate many lints in maint/add_warning 2022-06-24T13:23:38Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-24T12:24:00Z urn:sha1:23c352b96bf07c981bb396fa34ce83e512ada0b2 Found these by disabling the nightly dbg macro special case. Now, we have a mechanism for globally adding suppressions to tests, we can use that instead.