mirrors/arti.git/crates/tor-async-utils/src/sink_try_send.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
tor-async-utils: impl `SinkTrySend` for `mpsc::UnboundedSender`2025-08-05T19:57:35ZSteven Engleropara@torproject.org2025-07-31T19:47:15Zurn:sha1:961e980ce8ccf55aff4fb3820f886b58abca59d0Fix errors from rustdoc nightly.2025-08-05T13:34:23ZNick Mathewsonnickm@torproject.org2025-08-05T13:34:23Zurn:sha1:30a36b17593c10255ddd37eb7579c895c6629b67tor-async-utils: SinkTrySend: Fix a doc comment2024-10-02T13:05:56ZIan Jacksonijackson@chiark.greenend.org.uk2024-10-02T13:05:56Zurn:sha1:f0da07d87fe94a048567f730b8eff575fb8370b7
This was a copypaste error, resulting in a statement with the wrong
sense.
As per
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/2468#note_3086961
tor-async-utils: Avoid needless nesting of ErasedSinkTrySendError2024-10-01T17:29:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-30T16:36:36Zurn:sha1:75f27f45163bfc7b62893decd4184550ccc8d11dtor-async-utils: Provide tests for ErasedSinkTrySendError2024-10-01T17:29:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-30T15:56:04Zurn:sha1:34a3a34f3a7e4074ae32a575804865e8621b1f2ator-async-utils: Implement SinkTrySend for mpsc::Sender2024-10-01T17:29:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-30T16:25:01Zurn:sha1:84286777c28f8e1827589377b2ee55c79db501dbtor-async-utils: Provide new SinkTrySend trait2024-10-01T17:29:40ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-30T16:12:23Zurn:sha1:99c400a15cd449e5d4dd7eb44e9888d8a15c4a3f
This is the method try_send from mpsc::channel::Sender. We want to be
able to replace that type in tor-circmgr with a memquota wrapper, so
the call needs to be a trait method.
This API is deceptively simple.
Implementing it will involve more support machinery for error handling.