mirrors/arti.git/crates/slotmap-careful/src, branch arti-v1.8.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.8.02025-11-06T11:28:22ZFix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Remove "doc_auto_cfg" incantation from all crates.2025-09-29T19:30:03ZNick Mathewsonnickm@torproject.org2025-09-29T18:30:14Zurn:sha1:808b0ec2e3735a6dbbebeb857a3d6040ae02c697
This feature has been removed from nightly, in favor of doc_cfg.
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Temporarily suppress mismatched_lifetime_syntaxes.2025-07-07T15:50:04ZGabriela Moldovangabi@torproject.org2025-07-07T15:50:04Zurn:sha1:a11b611466a5a73f5e06a0aabd17284a57d12fe3
See #2060.
clippy: deny `mod_module_files`2025-01-06T23:09:41ZSteven Engleropara@torproject.org2025-01-06T23:02:49Zurn:sha1:252a3a803b2db65792db5bd51dee8950d8557e0d
Denies 'mod.rs' files for consistency.
https://rust-lang.github.io/rust-clippy/master/index.html#mod_module_files
add_warnings, *: Allow clippy::needless_lifetimes2024-12-03T14:27:26ZNick Mathewsonnickm@torproject.org2024-12-03T14:15:50Zurn:sha1:64cc3f2ed3eea0b7c5cc89ae07cbdadfdc1646fb
In 1.83, this warning triggers on many of our crates.
We're thinking of fixing them all, but for now,
we're going to disable the warning.
This is part of #1765.
Convert a few crates to slotmap-careful2024-10-17T16:54:37ZNeel Chauhanneel@neelc.org2024-10-15T01:16:24Zurn:sha1:e867cba7cbbbb1cf44e0017a5c354cd9f7a4aca6Fix typos2024-09-03T08:09:02ZDimitris Apostoloudimitris.apostolou@icloud.com2024-09-03T08:09:02Zurn:sha1:676f913463b7d84f34dd6101b99d03ef79cf57adslotmap-careful: Try to make test work with MSRV.2024-08-08T14:33:23ZNick Mathewsonnickm@torproject.org2024-08-08T14:33:23Zurn:sha1:9d8c9fd0b0ce7d7689a3c92252937e0d8d6b9bc9New `slotmap-careful` crate to use when we mustn't re-use keys.2024-08-08T14:15:49ZNick Mathewsonnickm@torproject.org2024-07-31T17:22:44Zurn:sha1:56f9cb5ddb70f5a49ae9b90945693cc7e7269e7c
This crate works as a drop-in replacement for
the generational arena types
`slotmap::{SlotMap, DenseSlotMap, HopSlotMap}`,
and is implemented a set of wrappers around those types.
The wrappers guarantee that slot versions numbers can never wrap
around by marking as unusable any slot whose version number
would otherwise get too high. (We add some leeway between our max
allowed version number and the largest possible version number,
so that we can detect bugs.)
The code relies on the serde encoding of slotmap key versions.
For notes on stability and (surprisingly good) performance,
see the comments.
Test coverage is around 98% for the lib.rs file; it's lower in
key_data.rs, since the error cases are unreachable given
slotmap's current behavior.
Open questions:
* What further testing is a good idea?
* Will slotmap ever upstream something like this?
See "# Limitations" comment for the parts of slotmap that are not
implemented; I hope that we don't need them.