mirrors/arti.git/crates/retry-error/src, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
retry-error: Port to web-time.2026-03-26T19:20:16ZNick Mathewsonnickm@torproject.org2026-03-26T12:12:55Zurn:sha1:0f24fc66741a75b5bf29f413d33ac081b71e0f50
This is independent of other crates, since this one is lower-level
than the tor-* crates.
Note that we're using std::time::SystemTime except for its `now`
method; this will be our practice elsewhere too.
retry-error: Remove unused variable2026-03-19T20:26:40ZTobias Stoeckmanntobias@stoeckmann.org2026-03-19T20:26:40Zurn:sha1:191c473add25ba82c865534b803ccaf99ec58b37
Spotted during review by gabi-250 in another test.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
retry-error: Simplify extend_from_retry_error2026-03-19T20:26:29ZTobias Stoeckmanntobias@stoeckmann.org2026-03-17T11:08:31Zurn:sha1:eaeeee952eae08e6843e550b524f3dff25b5c64b
With the newly introduced count function, extend_from_retry_error can be
simplified by spliting n_errors calculation from new_attempt creation.
retry-error: Allow dedup_by to merge ranges2026-03-19T20:26:17ZTobias Stoeckmanntobias@stoeckmann.org2026-03-17T11:04:24Zurn:sha1:cfb5922c6d32b037a73a604882739a73e78b5449
The dedup_by function grows the "last_attempt" always by one, even if a
range is encountered. A mergeable range can be encountered if the
RetryError has been extended by another RetryError already containing a
range.
Take this special case into account by using the actual amount of
failures of the attempt when growing.
Signed-off-by: Tobias Stoeckmann <tobias@stoeckmann.org>
retry-error: Fix typo in dedup_by description2026-03-17T11:10:15ZTobias Stoeckmanntobias@stoeckmann.org2026-03-17T11:03:38Zurn:sha1:5768e7752d8d17b72b5cd2719bddc341c840cf56
The function argument is named same_err, not dedup.
Merge branch 'ticket_2338' into 'main'2026-02-19T17:28:20ZNick Mathewsonnickm@torproject.org2026-02-19T17:28:20Zurn:sha1:61485a6893bf43deab6b2404a7d4e8ea0c722466
Use ErrorSources where appropriate to walk an error stack.
Closes #2338
See merge request tpo/core/arti!3685retry-error: Document why we don't need (and can't use) ErrorSources.2026-02-19T16:34:40ZNick Mathewsonnickm@torproject.org2026-02-16T15:41:59Zurn:sha1:d4883c3d333279c01a408495cdd70e33da5ade8bAllow clippy::collapsible_if to trigger2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T11:49:02Zurn:sha1:ade1d59e8e44c93b6ee447b72a2948a9652ec44e
`clippy::collapsible_if` started triggering after bumping the MSRV to
1.88.
Since this triggers from a lot of places, and since there even are a
couple of instances where we explicitly allow `clippy::collapsible_ifs`,
I've opened #2342 for deciding what to do about it.
maint/add_warning: Run script to add new warning2026-01-27T18:05:36ZGabriela Moldovangabi@torproject.org2026-01-27T18:05:36Zurn:sha1:a98faf72eb06b47700faeeac5a8a0dd0fc29b584
This adds the lint to all our crates.