mirrors/arti.git/crates/hashx, branch arti-v1.1.8mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.82023-09-05T17:43:19ZUpgrade bench/ lockfiles too.2023-09-05T17:43:19ZNick Mathewsonnickm@torproject.org2023-09-05T16:47:48Zurn:sha1:c63d913978acd7dc438d2316d497d5fe9d3ce116Update patchlevel for crates with nontrivial changes.2023-09-05T16:22:19ZNick Mathewsonnickm@torproject.org2023-09-05T16:22:19Zurn:sha1:e251baa9a77415f3c605ff462a8ac0b3fa37660a
These are:
```
hashx
equix
tor-async-utils
tor-error
tor-config
tor-rtmock
tor-llcrypto
tor-bytes
tor-hscrypto
tor-hspow
tor-cert
tor-linkspec
tor-cell
tor-proto
tor-netdoc
tor-netdir
tor-chanmgr
tor-guardmgr
tor-dirmgr
tor-keymgr
tor-hsclient
tor-hsservice
arti-client
arti
```
hashx: Cleanup around Instruction and NUM_INSTRUCTIONS2023-08-25T20:14:24ZMicah Elizabeth Scottbeth@torproject.org2023-08-25T20:11:47Zurn:sha1:2cb50d1be35a4a6623ff318fcf8ac2620521bb1f
This patch tries to make some of the expressions around NUM_INSTRUCTIONS
more convenient. We can import it directly where it's needed, but most
uses are replaced by new type aliases for InstructionArray and
InstructionVec.
No change to any hashx_cachegrind iai benchmarks
hashx: Avoid memcpy in Assembler::finalize()2023-08-25T19:46:44ZMicah Elizabeth Scottbeth@torproject.org2023-08-25T19:46:44Zurn:sha1:9d081f70363cac0a8de073588cf75f6870153dee
This is a very simple change, just passing 'self' by reference instead of
value. The by-value version generates a memcpy of the entire temporary
program buffer which doesn't optimize out like I expected it would.
The juicy impact here is a much lower cache footprint for compilation,
since we avoid having yet another temporary storage location for the program
data.
generate_compiled_1000x
Instructions: 271682605 (-0.627292%)
L1 Accesses: 341834751 (-0.813903%)
L2 Accesses: 56420 (-39.48365%)
RAM Accesses: 618 (-20.25806%)
Estimated Cycles: 342138481 (-0.867660%)
Rustfmt2023-08-25T17:12:56ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-23T11:00:15Zurn:sha1:cb151df6ab0a9fb28135b7a50e973e2c75c4a6fdRFC: hashx: Make Architecture::compile take an array ref2023-08-25T17:12:56ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-23T10:11:11Zurn:sha1:f789f0914b65391b293aac75ab86720028ffa88f
generate_interp_1000x
Instructions: 219216169 (No change)
L1 Accesses: 278017243 (-0.000441%)
L2 Accesses: 1257 (+4389.286%)
RAM Accesses: 415 (-0.479616%)
Estimated Cycles: 278038053 (+0.001744%)
generate_interp_1000x_c
Instructions: 272748034 (No change)
L1 Accesses: 349932964 (No change)
L2 Accesses: 76 (-1.298701%)
RAM Accesses: 411 (+0.243902%)
Estimated Cycles: 349947729 (+0.000009%)
generate_compiled_1000x
Instructions: 256896028 (+0.175731%)
L1 Accesses: 342543838 (+0.131802%)
L2 Accesses: 149273 (-10.34924%)
RAM Accesses: 810 (-0.246305%)
Estimated Cycles: 343318553 (+0.106328%)
generate_compiled_1000x_c
Instructions: 281855218 (No change)
L1 Accesses: 362569035 (-0.000001%)
L2 Accesses: 88 (+1.149425%)
RAM Accesses: 473 (+0.211864%)
Estimated Cycles: 362586030 (+0.000010%)
interp_u64_hash_1000x
Instructions: 13450926 (No change)
L1 Accesses: 16622561 (+0.000024%)
L2 Accesses: 28 (No change)
RAM Accesses: 390 (-1.015228%)
Estimated Cycles: 16636351 (-0.000817%)
interp_8b_hash_1000x_c
Instructions: 8618541 (No change)
L1 Accesses: 12316160 (-0.000008%)
L2 Accesses: 80 (No change)
RAM Accesses: 433 (+0.231481%)
Estimated Cycles: 12331715 (+0.000276%)
compiled_u64_hash_100000x
Instructions: 87311792 (+0.000520%)
L1 Accesses: 94396598 (+0.000463%)
L2 Accesses: 215 (+2.380952%)
RAM Accesses: 774 (-0.641849%)
Estimated Cycles: 94424763 (+0.000304%)
compiled_8b_hash_100000x_c
Instructions: 91547640 (No change)
L1 Accesses: 98838166 (-0.000007%)
L2 Accesses: 137 (+3.007519%)
RAM Accesses: 488 (+0.618557%)
Estimated Cycles: 98855931 (+0.000119%)
Run maint/add-warning2023-08-25T15:35:35ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-25T15:35:35Zurn:sha1:99b1a84566e8112bb954cf091e6260ed97390a19
Yet another new module concurrently with a new lint.
hashx: FixedCapacityVec: Fix clippy lints2023-08-24T16:55:30ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-24T16:55:30Zurn:sha1:500ea0e5f0fd14844b41bdbfb44c0ac9c7171a8fRustfmt2023-08-24T16:01:44ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-24T16:01:44Zurn:sha1:b1fd9934a166392e8dc0acada4b5bea376569fb5hashx: FixedCapacityVec: impl Send, Sync, [Ref]UnwindSafe2023-08-24T16:01:18ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-24T15:19:33Zurn:sha1:eaf5538ef3decc6b6612982708491ee57362f927