mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-1.2.1 2024-02-29T17:16:49Z 2024-02-29T17:16:49Z trinity-1686a trinity@deuxfleurs.fr 2024-02-29T17:06:46Z urn:sha1:ac5b36027ca825d27ef466501c660ce498fd9e3c 2024-01-08T18:19:11Z Dimitris Apostolou dimitris.apostolou@icloud.com 2024-01-04T18:32:22Z urn:sha1:4eb54be0657862f5d56b047c16c08dabde6a7377 2023-09-06T10:21:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-09-01T09:17:26Z urn:sha1:63db4c61fa3be9fc36e6b5117fa12edbeff33cd9 2023-08-25T20:14:24Z Micah Elizabeth Scott beth@torproject.org 2023-08-25T20:11:47Z urn:sha1:2cb50d1be35a4a6623ff318fcf8ac2620521bb1f This patch tries to make some of the expressions around NUM_INSTRUCTIONS more convenient. We can import it directly where it's needed, but most uses are replaced by new type aliases for InstructionArray and InstructionVec. No change to any hashx_cachegrind iai benchmarks 2023-08-25T19:46:44Z Micah Elizabeth Scott beth@torproject.org 2023-08-25T19:46:44Z urn:sha1:9d081f70363cac0a8de073588cf75f6870153dee This is a very simple change, just passing 'self' by reference instead of value. The by-value version generates a memcpy of the entire temporary program buffer which doesn't optimize out like I expected it would. The juicy impact here is a much lower cache footprint for compilation, since we avoid having yet another temporary storage location for the program data. generate_compiled_1000x Instructions: 271682605 (-0.627292%) L1 Accesses: 341834751 (-0.813903%) L2 Accesses: 56420 (-39.48365%) RAM Accesses: 618 (-20.25806%) Estimated Cycles: 342138481 (-0.867660%) 2023-08-25T17:12:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-23T11:00:15Z urn:sha1:cb151df6ab0a9fb28135b7a50e973e2c75c4a6fd 2023-08-25T17:12:56Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-23T10:11:11Z urn:sha1:f789f0914b65391b293aac75ab86720028ffa88f generate_interp_1000x Instructions: 219216169 (No change) L1 Accesses: 278017243 (-0.000441%) L2 Accesses: 1257 (+4389.286%) RAM Accesses: 415 (-0.479616%) Estimated Cycles: 278038053 (+0.001744%) generate_interp_1000x_c Instructions: 272748034 (No change) L1 Accesses: 349932964 (No change) L2 Accesses: 76 (-1.298701%) RAM Accesses: 411 (+0.243902%) Estimated Cycles: 349947729 (+0.000009%) generate_compiled_1000x Instructions: 256896028 (+0.175731%) L1 Accesses: 342543838 (+0.131802%) L2 Accesses: 149273 (-10.34924%) RAM Accesses: 810 (-0.246305%) Estimated Cycles: 343318553 (+0.106328%) generate_compiled_1000x_c Instructions: 281855218 (No change) L1 Accesses: 362569035 (-0.000001%) L2 Accesses: 88 (+1.149425%) RAM Accesses: 473 (+0.211864%) Estimated Cycles: 362586030 (+0.000010%) interp_u64_hash_1000x Instructions: 13450926 (No change) L1 Accesses: 16622561 (+0.000024%) L2 Accesses: 28 (No change) RAM Accesses: 390 (-1.015228%) Estimated Cycles: 16636351 (-0.000817%) interp_8b_hash_1000x_c Instructions: 8618541 (No change) L1 Accesses: 12316160 (-0.000008%) L2 Accesses: 80 (No change) RAM Accesses: 433 (+0.231481%) Estimated Cycles: 12331715 (+0.000276%) compiled_u64_hash_100000x Instructions: 87311792 (+0.000520%) L1 Accesses: 94396598 (+0.000463%) L2 Accesses: 215 (+2.380952%) RAM Accesses: 774 (-0.641849%) Estimated Cycles: 94424763 (+0.000304%) compiled_8b_hash_100000x_c Instructions: 91547640 (No change) L1 Accesses: 98838166 (-0.000007%) L2 Accesses: 137 (+3.007519%) RAM Accesses: 488 (+0.618557%) Estimated Cycles: 98855931 (+0.000119%) 2023-08-25T15:35:35Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-25T15:35:35Z urn:sha1:99b1a84566e8112bb954cf091e6260ed97390a19 Yet another new module concurrently with a new lint. 2023-08-24T16:55:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-24T16:55:30Z urn:sha1:500ea0e5f0fd14844b41bdbfb44c0ac9c7171a8f 2023-08-24T16:01:44Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-24T16:01:44Z urn:sha1:b1fd9934a166392e8dc0acada4b5bea376569fb5