mirrors/arti.git/crates/hashx/src/generator.rs, branch mainmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=main2026-05-12T20:55:43ZUpgrade rand crates to 0.10.2026-05-12T20:55:43ZWesley Aptekar-Casselsme@wesleyac.com2026-05-07T20:06:21Zurn:sha1:a18167928901d8c88cd1cdd87346de8ad1ee42a2
When the circ-padding feature is enabled, we use maybenot, which does
not yet support rand 0.10. In the meantime, enabling this feature pulls
in rand 0.9. This is not ideal, but should be okay as a temporary
situation.
This also replaces the use of ReseedingRng (which was removed in 0.10)
with the reseeding_rng crate. This is somewhat less performant, but it
should be okay.
hashx: Use .is_multiple_of() as recommended by clippy2026-02-16T15:22:24ZGabriela Moldovangabi@torproject.org2026-02-09T12:37:22Zurn:sha1:f637aa7288a5dd7263873ebbb101fc2c98510fe3
I'm applying the clippy suggestion, even though in this case, using
`is_multiple_of()` instead of `%` is a bit questionable IMO, because the
`% 3` operation can never panic.
Rename variables named "gen"2025-08-07T15:28:39ZNick Mathewsonnickm@torproject.org2025-08-06T02:01:09Zurn:sha1:9da44e30b2b61e80ca8cc89db272d9406347385d
This is now a reserved identifier. The automatic migration
changed it to a raw identifier (`r#gen`), but it's better to use a
different name.
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Update code for Edition 20242025-08-07T15:28:31ZNick Mathewsonnickm@torproject.org2025-08-07T12:44:47Zurn:sha1:0453fb4be8cf618b94230812957ce1db1afe74bd
1. Run cargo fix --edition
2. Selectively revert the "if let"->"match" changes.
These changes are meant to protect us from the lifetime changes
for "if let" bindings in Rust 2024.
But we're not actually relying on the old lifetime rules
anywhere, and the match syntax here is quite ugly.
3. Automatically revert `$pat:expr_2021` to `$pat:expr`.
(We don't actually want to restrict the expression syntax
that our macros accept).
Done with
`git grep -l expr_2021 | xargs perl -i -pe 's/expr_2021/expr/g;'`
4. Run cargo fmt.
hashx: Cleanup around Instruction and NUM_INSTRUCTIONS2023-08-25T20:14:24ZMicah Elizabeth Scottbeth@torproject.org2023-08-25T20:11:47Zurn:sha1:2cb50d1be35a4a6623ff318fcf8ac2620521bb1f
This patch tries to make some of the expressions around NUM_INSTRUCTIONS
more convenient. We can import it directly where it's needed, but most
uses are replaced by new type aliases for InstructionArray and
InstructionVec.
No change to any hashx_cachegrind iai benchmarks
Rustfmt2023-08-24T16:01:44ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-24T16:01:44Zurn:sha1:b1fd9934a166392e8dc0acada4b5bea376569fb5hashx: FixedCapacityVec: Move into its own module2023-08-24T12:50:20ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-24T12:23:20Zurn:sha1:6529846787aa65dc480edcca4a3e9cab1712e75bRustfmt2023-08-23T11:02:24ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-23T11:02:24Zurn:sha1:99def36084e65491482cd6871adc8972ccfd82eeRFC: hashx: Introduce FixedCapacityVec2023-08-23T10:59:24ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-23T10:48:40Zurn:sha1:3deb358cd2dd588baa560d347f1e69d078e28d9d
This is quite shoddy. It shouldn't be merged without some tidying up
and unit tests and so on. Also I am confused about the difference
between NUM_INSTRUCTIONS and model::REQUIRED_INSTRUCTIONS.
However:
generate_interp_1000x
Instructions: 220115418 (-1.147100%)
L1 Accesses: 278918725 (-0.936103%)
L2 Accesses: 25 (-98.46248%)
RAM Accesses: 414 (-0.956938%)
Estimated Cycles: 278933340 (-0.938920%)
generate_interp_1000x_c
Instructions: 272748034 (No change)
L1 Accesses: 349932970 (+0.000001%)
L2 Accesses: 76 (-1.298701%)
RAM Accesses: 405 (-0.491400%)
Estimated Cycles: 349947525 (-0.000021%)
generate_compiled_1000x
Instructions: 257344624 (-0.982784%)
L1 Accesses: 343007206 (-0.753942%)
L2 Accesses: 152502 (-17.12839%)
RAM Accesses: 809 (-0.369458%)
Estimated Cycles: 343798031 (-0.797384%)
generate_compiled_1000x_c
Instructions: 281855218 (No change)
L1 Accesses: 362569043 (+0.000002%)
L2 Accesses: 87 (-4.395604%)
RAM Accesses: 466 (-0.427350%)
Estimated Cycles: 362585788 (-0.000023%)
interp_u64_hash_1000x
Instructions: 13451818 (-0.100680%)
L1 Accesses: 16623452 (-0.105967%)
L2 Accesses: 28 (No change)
RAM Accesses: 392 (-1.507538%)
Estimated Cycles: 16637312 (-0.107138%)
interp_8b_hash_1000x_c
Instructions: 8618541 (No change)
L1 Accesses: 12316165 (+0.000032%)
L2 Accesses: 80 (-2.439024%)
RAM Accesses: 428 (-0.465116%)
Estimated Cycles: 12331545 (-0.000616%)
compiled_u64_hash_100000x
Instructions: 87312230 (-1.358594%)
L1 Accesses: 94397055 (-1.669415%)
L2 Accesses: 212 (-0.469484%)
RAM Accesses: 776 (-0.767263%)
Estimated Cycles: 94425275 (-1.669144%)
compiled_8b_hash_100000x_c
Instructions: 91547640 (No change)
L1 Accesses: 98838176 (+0.000009%)
L2 Accesses: 134 (-4.964539%)
RAM Accesses: 481 (-0.414079%)
Estimated Cycles: 98855681 (-0.000097%)