mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.5.0 2022-06-24T16:00:22Z 2022-06-24T16:00:22Z Nick Mathewson nickm@torproject.org 2022-06-24T16:00:22Z urn:sha1:20435aea751331817709acde8d4b65b5fb8d8f12 These were done with the following commands: ``` cargo set-version -p tor-basic-utils --bump patch cargo set-version -p fs-mistrust --bump minor cargo set-version -p tor-error --bump patch cargo set-version -p tor-config --bump patch cargo set-version -p tor-units --bump patch cargo set-version -p tor-rtcompat --bump minor cargo set-version -p tor-llcrypto --bump patch cargo set-version -p tor-bytes --bump minor cargo set-version -p tor-socksproto --bump minor cargo set-version -p tor-cert --bump minor cargo set-version -p tor-cell --bump minor cargo set-version -p tor-proto --bump minor cargo set-version -p tor-netdoc --bump patch cargo set-version -p tor-netdir --bump minor cargo set-version -p tor-persist --bump patch cargo set-version -p tor-chanmgr --bump minor cargo set-version -p tor-guardmgr --bump minor cargo set-version -p tor-circmgr --bump patch cargo set-version -p tor-dirclient --bump patch cargo set-version -p tor-dirmgr --bump minor cargo set-version -p arti-client --bump patch cargo set-version -p arti --bump minor cargo set-version -p arti-bench --bump minor cargo set-version -p arti-testing --bump minor ``` 2022-06-23T18:15:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-23T18:15:29Z urn:sha1:589c6e52bb49ccfe6c0ad9d18d6b994978e46c6c Update all lint blocks 2022-06-22T19:21:34Z Nick Mathewson nickm@torproject.org 2022-06-22T19:21:34Z urn:sha1:813a648ce248e2f43fc4257562e7da09549a02ae 2022-06-22T12:03:15Z Nick Mathewson nickm@torproject.org 2022-06-21T19:13:03Z urn:sha1:326ab1a7aecfeed7b26d820c0b64d14b45ef9bef These changes make sure that the errors conform to our preferred style, and include a description of what exactly we were doing when something went wrong. 2022-06-21T18:14:14Z Nick Mathewson nickm@torproject.org 2022-06-21T18:14:14Z urn:sha1:08d9bbf33b9fff8aa33a823422aa4e323137be07 According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323. 2022-06-02T11:15:52Z Ian Jackson iwj@torproject.org 2022-06-02T11:15:52Z urn:sha1:c2d8dac1ce7dcfe574d8ef2e9169adee89411371 fs-mistrust: Improve BadPermission string See merge request tpo/core/arti!554 2022-05-31T18:27:53Z Ian Jackson iwj@torproject.org 2022-05-31T18:27:53Z urn:sha1:98ccd7e7e2b2261009d2a2fb03e045513ef7ec85 lints: Make lint blocks consistent and ensure they stay that way Closes #469 See merge request tpo/core/arti!557 2022-05-31T18:23:01Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-30T18:18:20Z urn:sha1:bc6b02045ee4e5515f0f057998ef257638bffaf4 To me, "Incorrect permissions on file or directory /path: g=w o=w" implies that the current permissions on /path are 022. Change the message to "Incorrect permissions: /path is u=rwx,g=rwx,o=rwx; need g-w,o-w", which is closer to chmod syntax and is more useful in non-interactive environments such as CI and support. 2022-05-31T18:15:03Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-31T18:15:03Z urn:sha1:201107906ccbb00e96b27ac19108f46b85d278f7 Next commit adds another parameter to Error::BadPermission. 2022-05-31T14:23:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-31T10:46:13Z urn:sha1:4f42101554822c44782c164cac0051e3b4055abd From running add_warning, with manual picking of the right hunks/lines.