mirrors/arti.git/crates/fs-mistrust/src, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02024-02-12T11:38:36Zeduce: Use std's default for enums where default variant is unit2024-02-12T11:38:36ZIan Jacksonijackson@chiark.greenend.org.uk2024-02-12T11:07:42Zurn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a
Since Rust 1.66, std's default works properly for enums, provided that
the default variant is a unit.
Review all uses of `#[educe(default)]` on enums and replace them with
std where possible, which is most of them.
In 1.66 and later, std's `#[derive(Default)]` doesn't infer any
generic bounds on the derived impl, where it's an enum - since the
unit variant can always be constructed. So this change doesn't add
any generic bounds and is not API-visible.
fs_mistrust: Provide CheckedDir::make_secure_dir2024-01-29T11:15:12ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-25T18:57:50Zurn:sha1:98c82bd4285239ea452e765913cfef6b3c2ccb66
state_dir wants this, to descend into subdirectories.
I think the implementation could be improved - see the TODO.
fs_mistrust: Expose CheckedDir::verifier2024-01-25T19:11:17ZIan Jacksonijackson@chiark.greenend.org.uk2024-01-25T19:11:17Zurn:sha1:73a23394ec3b3e2da2a935f831deda27100b0e65
I'm not sure why this isn't public. It seems like an obviously
reasonable transformation.
If I as author of !1927 had been an external contributor, I could have
worked around the lack of .make_secure_directory() if .verifier() had
existed. So I think exposing it would be useful.
fs-mistrust: Explain where a Verifier comes from2023-12-13T17:02:45ZIan Jacksonijackson@chiark.greenend.org.uk2023-12-07T15:42:46Zurn:sha1:93c664440a551f37cac4f975e10683c7d4c10de2fs-mistrust: Add read_directory and remove_file to CheckedDir.2023-11-27T17:52:37ZNick Mathewsonnickm@torproject.org2023-11-26T18:21:33Zurn:sha1:d3e930ea8a62021c17873f46a5023e2f7cd77387
Closes #1117.
Run maint/add_warning to add lint block everywhere2023-08-23T09:34:00ZIan Jacksonijackson@chiark.greenend.org.uk2023-08-22T14:28:12Zurn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9acRun add_warnings on all files.2023-08-04T11:45:04ZNick Mathewsonnickm@torproject.org2023-08-04T11:45:04Zurn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953Run cargo +nightly fmt to format many let ... else ...2023-07-24T12:46:05ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-24T12:46:05Zurn:sha1:3e2a909707acf7cad2621316a51f8643f1fe908a
rustfmt has grown opinions about how let ... else ... ought to be
formatted. They don't always agree with our previous manual
decisions.
I think our policy is to always insist on rustfmt. When that version
of rustfmt hits stable, our CI will start to fail for everyone.
(Right now this discrepancy just causes trouble for contributors who
are using nightly by default.)
fs-mistrust: Run rustfmt to apply deferred formatting churn2023-07-14T15:02:45ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-14T14:10:37Zurn:sha1:967a36ee424aed0b0dbe216536990e7437e6b3a3fs-mistrust: In a test, simplify env var handling2023-07-14T15:02:45ZIan Jacksonijackson@chiark.greenend.org.uk2023-07-14T14:06:18Zurn:sha1:f137cbbe7c4e1d660685934a53027956cb5120a2