mirrors/arti.git/crates/fs-mistrust/src, branch arti-v1.1.13 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.13 2024-01-29T11:15:12Z fs_mistrust: Provide CheckedDir::make_secure_dir 2024-01-29T11:15:12Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-25T18:57:50Z urn:sha1:98c82bd4285239ea452e765913cfef6b3c2ccb66 state_dir wants this, to descend into subdirectories. I think the implementation could be improved - see the TODO. fs_mistrust: Expose CheckedDir::verifier 2024-01-25T19:11:17Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-01-25T19:11:17Z urn:sha1:73a23394ec3b3e2da2a935f831deda27100b0e65 I'm not sure why this isn't public. It seems like an obviously reasonable transformation. If I as author of !1927 had been an external contributor, I could have worked around the lack of .make_secure_directory() if .verifier() had existed. So I think exposing it would be useful. fs-mistrust: Explain where a Verifier comes from 2023-12-13T17:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-12-07T15:42:46Z urn:sha1:93c664440a551f37cac4f975e10683c7d4c10de2 fs-mistrust: Add read_directory and remove_file to CheckedDir. 2023-11-27T17:52:37Z Nick Mathewson nickm@torproject.org 2023-11-26T18:21:33Z urn:sha1:d3e930ea8a62021c17873f46a5023e2f7cd77387 Closes #1117. Run maint/add_warning to add lint block everywhere 2023-08-23T09:34:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-08-22T14:28:12Z urn:sha1:42df88d6bf6dbb460d2e5e1cd4838aafaffbe9ac Run add_warnings on all files. 2023-08-04T11:45:04Z Nick Mathewson nickm@torproject.org 2023-08-04T11:45:04Z urn:sha1:cec6d0ce33b4b5cebbce57f55faec83397e9c953 Run cargo +nightly fmt to format many let ... else ... 2023-07-24T12:46:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-24T12:46:05Z urn:sha1:3e2a909707acf7cad2621316a51f8643f1fe908a rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.) fs-mistrust: Run rustfmt to apply deferred formatting churn 2023-07-14T15:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-14T14:10:37Z urn:sha1:967a36ee424aed0b0dbe216536990e7437e6b3a3 fs-mistrust: In a test, simplify env var handling 2023-07-14T15:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-14T14:06:18Z urn:sha1:f137cbbe7c4e1d660685934a53027956cb5120a2 fs-mistrust: users: Use OsStr and OsString a lot less 2023-07-14T15:02:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-07-14T14:01:48Z urn:sha1:792371a68867a27ad22cc473c613c9402b6c73c3 We don't use OsString now except where it appears in our public API, or where we get it from std::env. Moving the `use` statements into the use sites enabled me to see that I had found all the places I wanted to change.