mirrors/arti.git/crates/fs-mistrust/src, branch arti-v1.0.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.0.1 2022-09-10T12:39:47Z fix clippy::needless_borrow 2022-09-10T12:39:47Z trinity-1686a trinity@deuxfleurs.fr 2022-09-10T12:39:47Z urn:sha1:8e7a904260dfe344eed70a9eef109695544347c1 Fix broken build and tests after arti!700. 2022-08-31T18:36:01Z Alexander Færøy ahf@torproject.org 2022-08-31T18:36:01Z urn:sha1:276d472739397b503d1992ad85030ab0865f5397 This patch fixes a minor build error where we would call `compact_home()` on Windows instead of `anonymize_home()` on our PathBuf instance. Additionally we change how the `arti_conf` path is constructed such that we join the individual path components to ensure that no "/" ends up being present on Windows where path's are separated by "\". See: tpo/core/arti#555. See: tpo/core/arti!700. Merge branch 'compact_home_2' into 'main' 2022-08-31T13:57:11Z Nick Mathewson nickm@torproject.org 2022-08-31T13:57:11Z urn:sha1:77cb5acceb39d7fc0e67693c55619b43923c6cea Represent the home directory as ${HOME} or %UserProfile% Closes #555 See merge request tpo/core/arti!700 Use anonymize_home() when displaying various messages. 2022-08-31T13:38:35Z Nick Mathewson nickm@torproject.org 2022-08-26T16:38:05Z urn:sha1:a9f19b00453ffd19fddb724f2b75f32ea1f37edb Closes #555 fs-mistrust: Add a `anonymize_home` extension fn for Path. 2022-08-31T13:38:09Z Nick Mathewson nickm@torproject.org 2022-08-26T13:06:23Z urn:sha1:7888ca09d281e6b6726e86d514ae00c8775a05ed This function transforms `/home/nickm/.config` to `${HOME}/.config/`, so that we can expose the username less in our logs. Comment out docstring as it fails to compile on Windows. 2022-08-30T20:07:44Z Alexander Færøy ahf@torproject.org 2022-08-30T20:07:44Z urn:sha1:5c3456ff88a4f5ca7e7019ecebfd80a41f235611 This patch comments out a method call to `trust_group()` as this method is not available on all platforms that Arti builds on right now and thus fails to compile there. I have added a comment that the given call is not available on non-Unix like platforms. See: tpo/core/arti#557. Disable 3 tests in fs-mistrust. 2022-08-30T20:06:47Z Alexander Færøy ahf@torproject.org 2022-08-30T20:06:47Z urn:sha1:a0bf6b1eebd0c26dc2c0c5c2cf6bfa34872577f3 This patch disables `readable_ok()`, `multiple_errors()`, and `check_contents()` as they all rely on permission issues on groups being detected properly which is not the case on Windows right now. See: tpo/core/arti#557. Use `expect()` instead of `unwrap()` in `mistrust_build()`. 2022-08-29T14:40:00Z Alexander Færøy ahf@torproject.org 2022-08-29T14:40:00Z urn:sha1:8668bd7bc9323c369c24d56004c6b405b0745bb4 See: tpo/core/arti#557. Refactor the construction of the `Mistrust` type in tests. 2022-08-29T14:22:57Z Alexander Færøy ahf@torproject.org 2022-08-29T14:22:57Z urn:sha1:d208706280fde565824198da1aafb8f686c940cd This patch refactors how we construct the `Mistrust` type in the tests found in the fs-mistrust crate such that it is possible to construct an instance of the `Mistrust` type using a set of operations available via the `MistrustBuilder`'s methods. We handle some of the portability issues found while testing this code on Windows in the convenience function `mistrust_build()` instead of having duplicated code in multiple test cases. See: tpo/core/arti#557. Document in link_rel() why we do not support symlinks on Windows. 2022-08-29T13:29:25Z Alexander Færøy ahf@torproject.org 2022-08-29T13:29:25Z urn:sha1:514aaf41b8a402c3f05d8d0bb6da80a70e034134 This patch adds a comment to the `link_rel()` function in fs-mistrust to explain why we ignore symlink creation on the Windows platform. See: tpo/core/arti#557.