mirrors/arti.git/crates/fs-mistrust/src/walk.rs, branch arti-v1.1.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.0 2022-09-10T12:39:47Z fix clippy::needless_borrow 2022-09-10T12:39:47Z trinity-1686a trinity@deuxfleurs.fr 2022-09-10T12:39:47Z urn:sha1:8e7a904260dfe344eed70a9eef109695544347c1 Merge branch 'compact_home_2' into 'main' 2022-08-31T13:57:11Z Nick Mathewson nickm@torproject.org 2022-08-31T13:57:11Z urn:sha1:77cb5acceb39d7fc0e67693c55619b43923c6cea Represent the home directory as ${HOME} or %UserProfile% Closes #555 See merge request tpo/core/arti!700 fs-mistrust: Add a `anonymize_home` extension fn for Path. 2022-08-31T13:38:09Z Nick Mathewson nickm@torproject.org 2022-08-26T13:06:23Z urn:sha1:7888ca09d281e6b6726e86d514ae00c8775a05ed This function transforms `/home/nickm/.config` to `${HOME}/.config/`, so that we can expose the username less in our logs. Mark the repeats and looping tests in fs-mistrust as Unix-only. 2022-08-26T19:30:20Z Alexander Færøy ahf@torproject.org 2022-08-26T19:30:20Z urn:sha1:edec8f3ecd37b759e911c66855cc3efb16cb8938 See: tpo/core/art#557. fs-mistrust: Try to handle verbatim prefixes in test. 2022-08-26T14:56:32Z Nick Mathewson nickm@torproject.org 2022-08-26T14:50:22Z urn:sha1:c1f64144b3f3c73e3e7b5d439d73dfe2352ae57c We have a test that tries to check that our outputs are the same as those from `std::fs::canonicalize`. But on Windows, they aren't: There, `canonicalize` also puts path prefixes into a "Verbatim" form. This patch tries to replicate that behavior for the test only. If we find that it's unreliable, though, our best bet is probably to revise or disable this check on Windows, rather than chasing compatibility with `GetFinalPathNameByHandle`. Should fix part of #557. fs-mistrust: Clarify comment on `stack` 2022-08-26T14:14:40Z Ian Jackson iwj@torproject.org 2022-08-26T14:14:40Z urn:sha1:ca4ca75ede5b3d6f89ba878f935941d9400b0ea3 fs-mistrust: Handle windows prefixes specially. 2022-08-26T13:43:08Z Nick Mathewson nickm@torproject.org 2022-08-26T13:36:30Z urn:sha1:5e7a62dff26640e7a97e69e8a499a57eacdc8a5f On Windows, paths can have a "prefix", like `C:` or `\\server\share`. Attempts to get metadata for these prefixes appear to fail with `ERROR_INVALID_FUNCTION`, since they are not files. This patch teaches fs-mistrust about prefixes on Windows, and tells it that attempts to find their metadata are allowed to fail. Doing this may solve part of #557. fs-mistrust: write a lot about TOCTOU issues. 2022-05-03T14:03:32Z Nick Mathewson nickm@torproject.org 2022-05-03T13:56:23Z urn:sha1:f35b4881295f52c252236b151764e82dbcb3b332 fs-mistrust: refactor ResolvePath to avoid temporary changes. 2022-05-03T14:03:32Z Nick Mathewson nickm@torproject.org 2022-04-27T15:58:30Z urn:sha1:c09a613590a0e2b8b6e3fcea601f6dfddab7b60a Previously we would temporarily put self.resolved into an invalid state by adding a path component that might be a symlink. With this change, we create a new temporary path object (using Cow to avoid unnecessary allocations) and only conditionally replace self.resolved. fs-mistrust: clarify and test behavior for ".." past the fs root. 2022-05-03T14:03:32Z Nick Mathewson nickm@torproject.org 2022-04-27T15:36:49Z urn:sha1:8e25954c49aff0b1fc64fea0b7457e029b1c805d