mirrors/arti.git/crates/fs-mistrust/src/user.rs, branch arti-v1.1.12

Run maint/add_warning to add lint block everywhere

2023-08-23T09:34:00Z

Run cargo +nightly fmt to format many let ... else ...

2023-07-24T12:46:05Z

rustfmt has grown opinions about how let ... else ... ought to be formatted. They don't always agree with our previous manual decisions. I think our policy is to always insist on rustfmt. When that version of rustfmt hits stable, our CI will start to fail for everyone. (Right now this discrepancy just causes trouble for contributors who are using nightly by default.)

fs-mistrust: Run rustfmt to apply deferred formatting churn

2023-07-14T15:02:45Z

fs-mistrust: In a test, simplify env var handling

2023-07-14T15:02:45Z

fs-mistrust: users: Use OsStr and OsString a lot less

2023-07-14T15:02:45Z

We don't use OsString now except where it appears in our public API, or where we get it from std::env. Moving the `use` statements into the use sites enabled me to see that I had found all the places I wanted to change.

fs-mistrust: Remove a now-unneeded suppression

2023-07-14T15:02:45Z

This function is actually (properly) fallible now.

fs-mistruct: Abolish some now-unneeded muts

2023-07-14T15:02:45Z

MockPwdGrpProvider has internal mutability and is Sync, so its add functions take &self.

fs-mistrust: Use pwd-grp's getgroups function

2023-07-14T15:02:45Z

This gets rid of some unsafe code here, with doubtful error handling, in favour of the unit-tested version in pwd-grp.

fs-mistruct: switch from users to pwd-grp

2023-07-14T15:02:45Z

users is unmaintained. pwd-grp is the crate I have just written to replace it. In this commit: Change the cargo dependency and imports. Replace the cacheing arrangements. users has a built-in cache; pwd-grp doesn't. Now, instead of cashing individual lookups, we cache the trusted user and trusted gid calculation results. This saves on some syscalls, and is also more convenient to write. (Mocking is still done via the dependency.) Many systematic consequential changes of details: * The entrypoint names to the library are different: pwd-grp uses the names of the corresponding Unix functions. * pwd-grp's returned structs are transparent, so we don't call accessors for .uid(), .name(), etc. * pwd-grp's methods are much more often fallible (returning io::Result) * We're using the non-UTF-8 pwd-grp API, which means we must use turbofish syntax in some places. * The mocking API is a bit different.

fs-mistrust: Introduce tempoary PwdGrpProvider alias

2023-07-14T15:02:45Z

This allows us to change a number of trait bounds in advance, reducing noise in the next commit.