mirrors/arti.git/crates/fs-mistrust/src/lib.rs, branch tor-dirmgr-v0.5.1 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-dirmgr-v0.5.1 2022-06-23T18:15:42Z Run maint/add_warning crates/*/src/{lib,main}.rs 2022-06-23T18:15:42Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-23T18:15:29Z urn:sha1:589c6e52bb49ccfe6c0ad9d18d6b994978e46c6c Update all lint blocks Merge branch 'better-fs-mistrust-badpermissions-string' into 'main' 2022-06-02T11:15:52Z Ian Jackson iwj@torproject.org 2022-06-02T11:15:52Z urn:sha1:c2d8dac1ce7dcfe574d8ef2e9169adee89411371 fs-mistrust: Improve BadPermission string See merge request tpo/core/arti!554 Merge branch 'lint' into 'main' 2022-05-31T18:27:53Z Ian Jackson iwj@torproject.org 2022-05-31T18:27:53Z urn:sha1:98ccd7e7e2b2261009d2a2fb03e045513ef7ec85 lints: Make lint blocks consistent and ensure they stay that way Closes #469 See merge request tpo/core/arti!557 fs-mistrust: Improve BadPermission string 2022-05-31T18:23:01Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-30T18:18:20Z urn:sha1:bc6b02045ee4e5515f0f057998ef257638bffaf4 To me, "Incorrect permissions on file or directory /path: g=w o=w" implies that the current permissions on /path are 022. Change the message to "Incorrect permissions: /path is u=rwx,g=rwx,o=rwx; need g-w,o-w", which is closer to chmod syntax and is more useful in non-interactive environments such as CI and support. fs-mistrust: BadPermission(_, _) -> BadPermission(..) 2022-05-31T18:15:03Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-31T18:15:03Z urn:sha1:201107906ccbb00e96b27ac19108f46b85d278f7 Next commit adds another parameter to Error::BadPermission. lints: Add let_unit_value allow to all crates 2022-05-31T14:23:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-31T10:46:13Z urn:sha1:4f42101554822c44782c164cac0051e3b4055abd From running add_warning, with manual picking of the right hunks/lines. lints: Add lint block delimiters to every crate 2022-05-31T12:00:31Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-30T17:43:12Z urn:sha1:ba0843da4a7ba1e63846a286b870b893092e0a4f This was the result of: maint/add_warning crates/*/src/{lib,main}.rs and then manually curating the results. mistrust: Canonicalise prefix from Some("") to None 2022-05-30T15:00:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-27T16:10:40Z urn:sha1:0a324f843fdeadffa7f9fab381b4911563b2d8af This allows us to add the proper default example to the arti example config file. fs-mistrust: allow symlinks to have any permissions 2022-05-25T14:27:45Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-24T20:17:45Z urn:sha1:85b4b5620d294b27cdee01989d4f2a936f6f32f4 Make fs-mistrust configurable from the top level. 2022-05-24T14:54:02Z Nick Mathewson nickm@torproject.org 2022-05-23T15:31:47Z urn:sha1:b1fc4bd03bb4024cd5a467ccb682e88adf30bac7 This change requires a little refactoring of TorClientBuilder: now, instead of enabling or disabling mistrust, it enables or disables the decision to _override_ the mistrust in the config.