mirrors/arti.git/crates/fs-mistrust/src/file_access.rs, branch arti-v2.5.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.12026-06-09T15:36:01Zmaint: Run maint/add_warning to deny string slices2026-06-09T15:36:01ZClara Englercve@cve.cx2026-06-09T15:36:01Zurn:sha1:9f5752a77fb57052c06ead0eeae606831f1e8e97
This commit executes maint/add_warning with the just added change to
deny string slices except in tests.
I recommend auditing this by checking out the previous commit followed
by running the script yourself and then verifying that the diff is
identical to this commit.
This commit makes cargo clippy fail. We will add exceptions in the next
commit.
Fix name of clippy lint to unchecked_time_subtraction (2)2025-11-06T11:28:22ZIan Jacksonijackson@chiark.greenend.org.uk2025-11-06T11:23:25Zurn:sha1:a5fd5c48ea059a80cc1f6c50e248654b5ff3aaff
Run maint/add_warning
Switch Cargo.toml files to edition 2024.2025-08-07T15:28:36ZNick Mathewsonnickm@torproject.org2025-08-06T01:19:58Zurn:sha1:77b0de43b8c67cdb81befe0680a3df43b6ad37bc
First, run
```
git grep -l "^edition =" |
xargs perl -i -pe 's/^edition *=.*/edition = "2024"/;'
```
Second, manually verify that all Cargo.toml files have changed,
and nothing else has changed.
Third, run cargo fmt again.
Fix Windows compile warnings2025-08-05T06:10:18ZTobias Stoeckmanntobias@stoeckmann.org2025-08-03T08:44:23Zurn:sha1:1623fd32272131c911ff53e8a2ea7b2516ffab07
Use unix-specific crates only if needed and suppress clippy warnings of
unused variables if their usage is unix-specific.
fs-mistrust: document that follow_final_links is not insecure2025-01-28T15:55:13ZNick Mathewsonnickm@torproject.org2025-01-28T15:55:13Zurn:sha1:ba3b957961bd4dfb93bb471b3f1f99367c9b47e3
Since it makes an exception, we need to be clear about the
exceptions that it _doesn't_ make.
fs-mistrust: link to documentation about "obeying constraints"2025-01-28T15:32:02ZNick Mathewsonnickm@torproject.org2025-01-28T15:32:02Zurn:sha1:b0e2280a402c38f2c2af612c7c8d766be0293a6f
Since "obeying the constraints of a FileAccess" is a term of art,
this commit introduces links from the places where it is used
to the place where it is defined.
fs-mistrust: Fix test compilation on windows.2025-01-16T13:49:30ZNick Mathewsonnickm@torproject.org2025-01-16T13:42:19Zurn:sha1:c0c96ee76cf701335813dffbcd5b3dbe5b853890
`std::os::unix::fs::MetadataExt` was indeed the right trait to
import, but it doesn't exist on non-unix platforms.
This is another bugfix on !2707. It should retain the fix of !2717.
I've confirmed that it builds on Windows and passes tests on Linux
and Mac.
Fix: Tests fails to run on macos2025-01-16T10:37:15Zhhamudself@hamzahamud.com2025-01-16T10:37:15Zurn:sha1:00489651b88f88960a07e4234ceb5869b36f81c9file_access: Refactor APIs to consume self.2025-01-14T20:41:32ZNick Mathewsonnickm@torproject.org2025-01-14T18:38:52Zurn:sha1:baa1535328af6c5e5362c7b533cb20fbad1bc707
This approach makes it even less likely for people to store a
FileAccess for repeated use.
file_access: Make link-following behavior explicitly controlled.2025-01-14T20:41:32ZNick Mathewsonnickm@torproject.org2025-01-14T18:28:30Zurn:sha1:75da8ad6518cd5218cb7289389431112bd6f5bbc