mirrors/arti.git/crates/fs-mistrust/src/file_access.rs, branch arti-v1.4.2 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.2 2025-01-28T15:55:13Z fs-mistrust: document that follow_final_links is not insecure 2025-01-28T15:55:13Z Nick Mathewson nickm@torproject.org 2025-01-28T15:55:13Z urn:sha1:ba3b957961bd4dfb93bb471b3f1f99367c9b47e3 Since it makes an exception, we need to be clear about the exceptions that it _doesn't_ make. fs-mistrust: link to documentation about "obeying constraints" 2025-01-28T15:32:02Z Nick Mathewson nickm@torproject.org 2025-01-28T15:32:02Z urn:sha1:b0e2280a402c38f2c2af612c7c8d766be0293a6f Since "obeying the constraints of a FileAccess" is a term of art, this commit introduces links from the places where it is used to the place where it is defined. fs-mistrust: Fix test compilation on windows. 2025-01-16T13:49:30Z Nick Mathewson nickm@torproject.org 2025-01-16T13:42:19Z urn:sha1:c0c96ee76cf701335813dffbcd5b3dbe5b853890 `std::os::unix::fs::MetadataExt` was indeed the right trait to import, but it doesn't exist on non-unix platforms. This is another bugfix on !2707. It should retain the fix of !2717. I've confirmed that it builds on Windows and passes tests on Linux and Mac. Fix: Tests fails to run on macos 2025-01-16T10:37:15Z hhamud self@hamzahamud.com 2025-01-16T10:37:15Z urn:sha1:00489651b88f88960a07e4234ceb5869b36f81c9 file_access: Refactor APIs to consume self. 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-14T18:38:52Z urn:sha1:baa1535328af6c5e5362c7b533cb20fbad1bc707 This approach makes it even less likely for people to store a FileAccess for repeated use. file_access: Make link-following behavior explicitly controlled. 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-14T18:28:30Z urn:sha1:75da8ad6518cd5218cb7289389431112bd6f5bbc Documentation fixes from Gabi 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-14T18:10:01Z urn:sha1:9ff31c66f2d37f66d33879b08e664844e5c52ae6 fs-mistrust: Try more to explain what FileAccess is for. 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-13T18:30:50Z urn:sha1:d662ba1ea9eb123f3ac54aa0988e07d061c5206c fs-mistrust: Follow symlinks when using file-access outside a CheckedDir. 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-13T17:13:38Z urn:sha1:7c04e3fa2fabe0b0a9ce8944253cd895c7c9a942 When we're not bound to a CheckedDir, it doesn't make sense to forbid following symlinks, so long as their targets are also sensible. fs-mistrust: Add FileAccess for Verifier (and Mistrust). 2025-01-14T20:41:32Z Nick Mathewson nickm@torproject.org 2025-01-13T14:46:23Z urn:sha1:f024a64f0cf80056ea4415803d511e70493066ef