mirrors/arti.git/crates/fs-mistrust/src/err.rs, branch arti-v1.1.5 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.5 2023-01-27T16:02:42Z add opaque ErrorHint API, impl ErrorHint from BadPermissions 2023-01-27T16:02:42Z Shady Katy katy@shady.zone 2022-10-04T13:00:06Z urn:sha1:cc4c07678ac013a2f321088f7d6202f29e38837b Allow clippy::unchecked_duration_subtraction in tests 2023-01-27T13:28:02Z Nick Mathewson nickm@torproject.org 2023-01-27T13:01:45Z urn:sha1:a6dd92843edf2bd4c58de62a0d562921e4191ada This panics on error, and we're fine with a panic on misbehavior in tests. test lint blocks: Add many many automatically 2022-12-12T18:00:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-12-12T17:58:40Z urn:sha1:125a455bdcca841931f33f83f206e57637ae85c4 This is precisely the result of running the rune in maint/adhoc-add-lint-blocks. Use anonymize_home() when displaying various messages. 2022-08-31T13:38:35Z Nick Mathewson nickm@torproject.org 2022-08-26T16:38:05Z urn:sha1:a9f19b00453ffd19fddb724f2b75f32ea1f37edb Closes #555 fs-mistrust: convert Io error variant to a struct. 2022-06-22T19:21:34Z Nick Mathewson nickm@torproject.org 2022-06-22T19:21:34Z urn:sha1:813a648ce248e2f43fc4257562e7da09549a02ae Editorial improvements on fs-mistrust errors 2022-06-22T12:03:15Z Nick Mathewson nickm@torproject.org 2022-06-21T19:13:03Z urn:sha1:326ab1a7aecfeed7b26d820c0b64d14b45ef9bef These changes make sure that the errors conform to our preferred style, and include a description of what exactly we were doing when something went wrong. Do not include error source() in display() format. 2022-06-21T18:14:14Z Nick Mathewson nickm@torproject.org 2022-06-21T18:14:14Z urn:sha1:08d9bbf33b9fff8aa33a823422aa4e323137be07 According to doc/Errors.md, and in keeping with current best practices, we should not include display an error's `source()` as part of that error's display method. Instead, we should let the caller decide to call source() and display that error in turn. Part of #323. fs-mistrust: Improve BadPermission string 2022-05-31T18:23:01Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-30T18:18:20Z urn:sha1:bc6b02045ee4e5515f0f057998ef257638bffaf4 To me, "Incorrect permissions on file or directory /path: g=w o=w" implies that the current permissions on /path are 022. Change the message to "Incorrect permissions: /path is u=rwx,g=rwx,o=rwx; need g-w,o-w", which is closer to chmod syntax and is more useful in non-interactive environments such as CI and support. fs-mistrust: BadPermission(_, _) -> BadPermission(..) 2022-05-31T18:15:03Z Alex Xu (Hello71) alex_y_xu@yahoo.ca 2022-05-31T18:15:03Z urn:sha1:201107906ccbb00e96b27ac19108f46b85d278f7 Next commit adds another parameter to Error::BadPermission. fs-mistrust: Add Group and User types. 2022-05-24T14:54:02Z Nick Mathewson nickm@torproject.org 2022-05-18T18:36:24Z urn:sha1:330582a142e30a80fe5f62af043955ca7373b7e7 This will help make the actual configuration more serializable, I hope.