mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-27T14:18:52Z 2022-05-27T14:18:52Z Nick Mathewson nickm@torproject.org 2022-05-27T14:18:52Z urn:sha1:4326aa1de9875ea399c3a608c0320bbe4b214a42 This commit was made by reverting the previous commit, then re-running the script I used to generate it. In theory there should be no semantic changes: only changes due to improved formatting from cargo edit. 2022-05-27T13:01:20Z Nick Mathewson nickm@torproject.org 2022-05-27T13:01:20Z urn:sha1:b232365a75249d6f767127feb2a47286f9ece762 I followed the following procedure to make these changes: * I used maint/changed_crates to find out which crates had changed since 0.3.0. * I used grep and maint/list_crates to sort those crates in topological (dependency) order. * I looked through semver_status to find which crates were listed as having semver-relevant changes (new APIs and breaking changes). * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no changes. For those crates, I incremented their patch-level version _without_ changing the version that other crates depend on. * I scanned through the git logs of the crates with no semver-relevant changes listed to confirm that, indeed, they had no obvious breaking changes. * I treated all crates that depend on `arti` and/or `arti-client` as having breaking changes. * I identified crates that depend on crates that have changed, even if they have not changed themselves, and identified them as having a non-breaking change. * For all of the crates, I used `cargo set-version -p $CRATE --bump $STATUS` (where `STATUS` is `patch` or `minor`) to update the versions, and the depended-upon versions. 2022-05-26T10:40:43Z Ian Jackson iwj@torproject.org 2022-05-26T10:40:43Z urn:sha1:4bf87d61ca94648a7af220342303748f1ae1d1b3 Break TorClientConfig out of ArtiConfig and warn on unknown config keys Closes #459 and #417 See merge request tpo/core/arti!529 2022-05-25T18:15:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-25T17:46:29Z urn:sha1:80ddae3d4b8669d614ed013acae01b19c266dc4d 2022-05-25T15:41:05Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-25T15:37:11Z urn:sha1:0803296bd6b6b8dba3265ee46bd838379077939d As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807077 2022-05-25T15:40:02Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-25T14:41:41Z urn:sha1:9f426e2c575890dc1037fb862fdcd1c1d7acd33b As per review comments https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/529#note_2807076 2022-05-24T22:02:14Z trinity-1686a trinity@deuxfleurs.fr 2022-05-24T22:02:14Z urn:sha1:801380780f1bd743e2bb8a0032e58fb94d1e3a6b 2022-05-24T19:14:57Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-24T11:39:49Z urn:sha1:bb8e205b0da8833e56967b5d6b80f4b1c0a1e144 2022-05-24T19:14:57Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-24T18:07:25Z urn:sha1:9e526aad7c4ca37e8ee9b082449da6493b6e475b This gets rid of `#[serde(flatten)]` which prevents serde_ignored (and other kinds of introspection) from working properly. The price is now that the toplevel has to deal with two configuration objects. The Resolvable trait is overkill right now, but is going to do More Things in a moment. In particular, we need the impl on tuples, so that the whole config can be processed in one go. 2022-05-24T19:08:40Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-24T17:41:56Z urn:sha1:d15cc758216a3c809139acf2c21f74d96d99f71d We are going to reorganise ArtiConfig to not contain a TorClientConfig. This test case's calls to bld.tor() will all need to change. Do this in advance to make that future commit more readable.