mirrors/arti.git/crates/arti/tests/cli_tests, branch arti-v2.5.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.5.02026-06-17T22:35:48Zarti: Gate the "arti keys" tests behind onion-service-service2026-06-17T22:35:48ZGabriela Moldovangabi@torproject.org2026-06-17T22:30:52Zurn:sha1:a75a1c5c70181f6ab40b177bfac07eb4eda764ae
Now that these test more than just the help output, we need to gate them
behind the `onion-service-service` feature: the tests involve some C Tor
keystores, and require at least one onion service to be configured,
because onion services (and clients) are the only thing these keystores
are used for.
arti: Remove no longer used test helper2026-06-17T22:09:04ZGabriela Moldovangabi@torproject.org2026-06-17T18:07:45Zurn:sha1:1436f750ab25b98c966c31bcf1d3ccf0f777bc9earti: Remove now-obsolete keys test module2026-06-17T22:02:58ZGabriela Moldovangabi@torproject.org2026-06-17T17:52:55Zurn:sha1:3a40f26006134074c1fb88bc0f97d3d6b85c4782
We now have `trycmd` tests that cover most cases, so I am removing this
module. The reason this was introduced in the first place is in the
module level docs
```rust
//! The `assert_cmd` crate is used here instead of the preferred `trycmd` (see
//! [`README`](../README.md)) because the output of `keys list` is not deterministic across
//! different machines. The design choices of some components are workarounds for this limitation.
```
But this is no longer an issue now that the `keys list` output is
sorted.
Ideally, all tests would be written this way (we have a few more modules
in `cli_tests` that we should probably port to `trycmd` sometime).
Note: some of the tests I'm removing here don't have a `trycmd`
counterpart in `arti/tests/testcases/keys`. In my opinion, this is
perfectly fine, because the old tests were unnecessarily testing all the
possible configurations involving 1-2 keystores (one arti, and one C
Tor): it is not the responsibility of the CLI tests to cover all these
permutations (they should be tested in `tor-keymgr`).
arti, keymgr: s/IDEA/TODO2026-06-17T16:18:26ZGabriela Moldovangabi@torproject.org2026-06-17T15:46:44Zurn:sha1:18115a11225b9aaf3106512aa49ae84bf1c3eeb6
It's better to use "TODO" like we do in the rest of Arti, because
otherwise this has a chance of being forgotten (because nobody really
greps for "IDEA").
arti: subcommands: keys: Rework output of keys list2026-06-17T16:17:59Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-06-17T16:17:59Zurn:sha1:e98b4a466fd6db9afd691ee3e9a74d3b4f5f90c9arti: tests: Add regression test for `arti -h`2026-04-08T13:38:06Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-04-07T11:30:18Zurn:sha1:09fd697cea0434e87dee3e21a458662bc2961e92
- Add regression test
- Update README
arti: test: rename unrecognized-entry to hs_unrecognized_entry to fix the CI2026-03-30T12:43:51Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-03-30T12:43:51Zurn:sha1:f8a1e0032acde04dcf298fa05ccc80778cbfe6ea
This changes save us from adding a new entry in .editorconfig
arti: test: correct typo in hss.rs2026-03-30T12:08:17Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-03-30T12:08:17Zurn:sha1:d182ecef1a54c12dcc73e1099a172b4ef9d18169arti: test: Add description of the test file structure of the keys test suite2026-03-30T12:05:21Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-03-30T12:05:21Zurn:sha1:62adf34a1fac6993287dadbe0cf1d95e30e80175arti: tests: Rename some keys test files using more intuitive names2026-03-30T11:33:42Zhjrgrn3874-hjrgrn@gitlab.torproject.org2026-03-30T11:33:42Zurn:sha1:f1bed5a40563b36b2bf2d1eb3c14a98f86601094