mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-06T11:38:16Z 2022-05-06T11:38:16Z Nick Mathewson nickm@torproject.org 2022-05-04T13:21:40Z urn:sha1:b879125668db7416ba527793fe56e4a50a00436a 2022-05-06T11:38:14Z Nick Mathewson nickm@torproject.org 2022-05-04T13:13:29Z urn:sha1:7e34692a65c02dbcf2bb1cd330ab9665a017d52e Here we add a config option to disable safe logging, and ensure that safe logging is disabled when we are formatting an error message on exit (since we assume it's safe to write sensitive info to stderr.) 2022-05-06T11:36:50Z Nick Mathewson nickm@torproject.org 2022-05-02T23:44:12Z urn:sha1:4679023c39bc8658b6f1d44bc6bda8074c485520 This specifically applies the `sensitive` wrapper in the places where we're logging target addresses at level "info" or higher. 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-05T09:19:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T17:41:35Z urn:sha1:2c1282f537ef89389e537e849ee906cc53d0f811 We want to be able to serialise as well as deserialise configurations. 2022-05-04T16:18:55Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T15:20:08Z urn:sha1:4ad4cae4180981856676f675e32117b683518f4e And drop the ad-hoc orport() method. This brings FallbackDir's orports field in line with our list builder API. The general semver note in "configuation" seems to cover most of this. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-04-26T18:47:08Z Nick Mathewson nickm@torproject.org 2022-04-26T18:47:08Z urn:sha1:5484bcc21f89d19d30e6351670c36359c132f718 DownloadSchedule: Introduce Builder See merge request tpo/core/arti!473 2022-04-26T14:16:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-26T13:46:07Z urn:sha1:eb35555330d84ef931dbfd446f5495ff0172b17e Use sub_builder. We must do something special for defaults. This involves moving the actual default values for retry_bootstrap and retry_microdescs into config.rs, since they need to access the fields of the un-built version of the structure. (An alternative would be to generate "weak setters" which do not override previous settings, but derive_builder does not offer to generate them and that seems overkill.) 2022-04-26T14:16:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T18:26:27Z urn:sha1:f4a1e34beebbd891f2a3f1474028ac6ac7f738b2 Instead, everyone should use DownloadScheduleBuilder. The new() method would in any case be useless in a moment, since we're going to embed DownloadScheduleBuilder in the NetworkConfig, not DownloadSchedule. The call sites in the tests are all about to change again.