mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.0.2 2021-11-25T13:20:37Z 2021-11-25T13:20:37Z Daniel Eades danieleades@hotmail.com 2021-11-25T13:14:05Z urn:sha1:db16d13df4779ac61005050dfe5ce05e3d5a1b5d 2021-11-24T23:23:12Z Nick Mathewson nickm@torproject.org 2021-11-24T23:23:12Z urn:sha1:3e7e599a22972135f9c113a9a1e0757d22653481 2021-11-24T23:12:44Z Nick Mathewson nickm@torproject.org 2021-11-24T22:31:42Z urn:sha1:f55950ab8d86fec3c5fbe33650c4a7001f9812b3 Also fix some commonwealth spellings that had slipped in. 2021-11-18T16:48:14Z Nick Mathewson nickm@torproject.org 2021-11-18T16:48:14Z urn:sha1:a1a620e451ba7d390b543e4f444e677c9d7e30a2 Now there are no options that aren't in a toml section. 2021-11-18T16:37:48Z Nick Mathewson nickm@torproject.org 2021-11-17T19:16:55Z urn:sha1:5184f5ba84d76b75022fe6249ba18fe42807b1aa To do this at all neatly, I had to split out `tor-config` from `arti-config` again, and putting the lower level stuff (paths, builder errors) into tor-config. I also changed our use of derive_builder to always use a common error type, to avoid error type proliferation. 2021-11-04T15:13:29Z Nick Mathewson nickm@torproject.org 2021-11-04T15:13:29Z urn:sha1:753cbc96263714d065ec92353923f1abbff3f67c This patch makes the rust-nightly CI task fail if it detects any dbg!(), println!(), or eprintln!() calls in production code. Because of clippy limitations, it may also gripe about calls to these macros in our tests. The preferred workarounds are to either instead. Both are acceptable. We're doing this check in CI rather than unconditionally with clippy directives, since we often want to have these calls in our code temporarily while we're developing. Some day we might want this test to go into a pre-push hook. This patch also adds #![allow()] directives for println!() and eprintln!() in the arti crate. Since that one isn't a library, it's okay for it to speak to stdout/stderr. Closes #218. 2021-11-04T14:54:47Z Nick Mathewson nickm@torproject.org 2021-11-04T14:54:47Z urn:sha1:dae8cdb463d94b444ecd465f3a52fdc5a8ed3ede 2021-10-29T00:22:49Z Nick Mathewson nickm@torproject.org 2021-10-29T00:22:49Z urn:sha1:4107533d77e51d9653d76dabbd893197fb176c65 2021-10-27T18:11:48Z eta tor@eta.st 2021-10-27T16:40:00Z urn:sha1:4fa0122dde2b664ebd10bfbe46da54c396dffdb3 This switches out `arti`'s argument-parsing library with `clap`, which is a lot more featureful (and very widely used within the Rust ecosystem). We also now use a lot of `clap`'s features to improve the CLI experience: - The CLI now expects a subcommand (currently, either "help", or "proxy" for the existing SOCKS proxy behaviour). This should let us add additional non-SOCKS-proxy features to arti in future. - `clap` supports default values determined at runtime, so the way the default config file is loaded was changed: now, we determine the OS-specific path for said file before invoking `clap`, so the help command can show it properly. - The behaviour of `tor_config` was also changed; now, one simply specifies a list of configuration files to load, together with whether they're required. - That function also way overused generics; this has been fixed. - Instead of using the ARTI_LOG environment variable to configure logging, one now uses the `-l, --log-level` CLI option. (The intent is for this option to be more discoverable by users.) - The `proxy` subcommand allows the user to override the SOCKS port used on the CLI without editing the config file. 2021-10-27T15:13:46Z Nick Mathewson nickm@torproject.org 2021-10-27T15:13:46Z urn:sha1:134c04a67adebff719011b608dabfa6da60ed247