mirrors/arti.git/crates/arti/src/watch_cfg.rs, branch derive-traits

Upgrade to newer version of config crate.

2022-02-25T14:20:48Z

Properly linkify two doc comment xrefs to issues

2022-02-04T15:11:44Z

Fixes these messages: warning: this URL is not a hyperlink --> crates/arti/src/watch_cfg.rs:115:5 | 115 | /// https://github.com/notify-rs/notify/issues/165 and | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `` | = note: `#[warn(rustdoc::bare_urls)]` on by default = note: bare URLs are not automatically turned into clickable links warning: this URL is not a hyperlink --> crates/arti/src/watch_cfg.rs:116:5 | 116 | /// https://github.com/notify-rs/notify/pull/166 . | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `` | = note: bare URLs are not automatically turned into clickable links

Document that `notify` behavior is strange with symlinks

2022-02-03T16:11:21Z

(More specifically, `notify` behaves differently on different platforms. On some, it can watch specific directory objects on the filesystem, and so it only notices when _those_ directories change. If you change a symlink so that the canonical configuration file location is now in some other directory, `notify` won't notice. But on other platforms, notify just does "stat()" in a loop. On those, it _will_ notice if the configuration file changes.)

Avoid a potential infinite loop in configuration-watching

2022-02-03T14:38:58Z

Since the user can put their logfiles and configuration files in the same directory, writing to the log can trigger an event from `notify`. If we log every non-interesting event from `notify`, then we'll trigger the logs every time we log, and fill up the disk. This commit removes the offending log and adds a comment about why. If we someday decide we do need to log here, maybe we can rate-limit the messages or something.

Treat rescan events as meaning "reload configuration".

2022-02-03T14:36:12Z

Add a couple of TODOs about configuration-watching.

2022-02-02T20:43:42Z

Before reloading configuration, drain all pending file changes

2022-02-02T20:43:42Z

This way, if there are a bunch of changes at once, we only reload one time.

Refactor file-watching code to watch parent directories.

2022-02-02T20:43:39Z

Due to limitations in notify and the OS APIs it uses, it isn't actually so useful to watch a single file. Instead, we have to watch the directories that contain the files, and filter out any events that aren't about the specific files we care about. I've put the logic here into a new type, but I've left the type un-exported: its API is pretty ugly, inasmuch as the caller needs to jump through hoops to only get the events that they want. That's not too bad so long as the API is private, but we'd want better if we were exposing this.

Detect changes in non-client configuration sections too

2022-02-01T21:04:59Z

We don't yet do much with these, but we can avoid discarding them.

Reload configuration when our configuration files change.

2022-02-01T21:04:53Z

Closes #270