mirrors/arti.git/crates/arti/src/subcommands/keys.rs, branch arti-v2.0.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v2.0.02026-01-06T15:25:19Zkeymgr: Move Unrecognized errors out of KeyPathError2026-01-06T15:25:19ZGabriela Moldovangabi@torproject.org2026-01-05T11:07:23Zurn:sha1:0f2b9e7914580e2b0c58936c22f80996781df014
Out of all the variants in `KeyPathError`, `Unrecognized` is the odd one
out, because unlike the others, which are mainly just lower level
parsing errors, `Unrecognized` is a higher level error constructed in
`KeyMgr::describe()`.
`KeyMgr::describe()` now returns an `Option`, because
* the failure to describe a user provided `KeyPath` may or may not be
an error
* previously, `describe()` would only ever return `Ok` or
`Err(KeyPathError::Unrecognized)`, which essentially a binary
result. Also, `describe()` would never return any of the other
`KeyPathError` kinds, which further suggests `Unrecognized`
doesn't belong there
The `Unrecognized` variant still exists, but is now part of
`KeystoreCorruptionError`, (returned from
`KeyMgr::validate_entry_integrity()`).
arti: Remove no-longer needed helper function2026-01-06T15:25:19ZGabriela Moldovangabi@torproject.org2026-01-04T16:51:19Zurn:sha1:c273bda604b2157cba3588f2a8dd2bcdbbc83773
This folds `display_arti_entry()` into `display_entry()`.
arti: Remove special handling for C Tor keys (fmt)2026-01-06T15:25:19ZGabriela Moldovangabi@torproject.org2025-12-15T17:48:27Zurn:sha1:29a3d1b8e50119493b5d219c40ca6a9972c48f9earti: Remove special handling for C Tor keys2026-01-06T15:25:19ZGabriela Moldovangabi@torproject.org2025-12-15T17:48:03Zurn:sha1:1e34e17849be8b25c1434c1397dc9192dd0fead1
This is no longer needed now that `KeyMgr::describe()` works on
`CTorPath`s.
Removing this special handling has the added bonus that the keymgr CLI
output is now uniform for all keystores (before this change, `keys list`
used a slightly different output format for displaying C Tor entries).
The corresponding tests will be updated in a future commit.
Merge branch 'torclient-keymgr-accessor' into 'main'2025-12-03T19:26:54Zwesleyacwesleyac@torproject.org2025-12-03T19:26:54Zurn:sha1:f75058f04bfec47df65a2bdbec7254c46ba57517
Add `KeyMgr` accessor to `TorClient`
See merge request tpo/core/arti!3442arti: Add missing subcommand docs2025-12-01T12:36:13ZGabriela Moldovangabi@torproject.org2025-12-01T11:11:53Zurn:sha1:9003ad28c1f3a82b33d8269e33700082fbbce2a8arti: keys: use `TorClient::keymgr` instead of `InertTorClient::keymgr` in `run_check_integrity`2025-11-05T09:33:51Zhjrgrn3874-hjrgrn@gitlab.torproject.org2025-11-05T09:20:22Zurn:sha1:a00d1edaf0d15bed098ac99d0f82a58572a0028c
This change simplifies the signature of `run_check_integrity`.
arti: keys: Simplify `run_check_integrity`2025-10-08T12:00:38Zhjrgrn3874-hjrgrn@gitlab.torproject.org2025-10-02T14:33:09Zurn:sha1:57fd92224eb2aa3087a3ea81bca76b35caae5925arti: keys: Improve readability of `print_check_integrity_incipit`2025-10-08T12:00:38Zhjrgrn3874-hjrgrn@gitlab.torproject.org2025-10-02T09:28:24Zurn:sha1:90467352d46b6d1562313559dd6e6f2456837508arti: keys: Fix typo in `run_check_integrity`2025-10-08T12:00:38Zhjrgrn3874-hjrgrn@gitlab.torproject.org2025-10-02T09:04:54Zurn:sha1:0ec18744fc2107ef14a35e9f1fad1137dac23400