mirrors/arti.git/crates/arti/src/socks.rs, branch ios-sqlite-hacksmirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks2023-07-07T17:00:21ZThroughout: Use *_report!() macros for reporting Errors.2023-07-07T17:00:21ZNick Mathewsonnickm@torproject.org2023-07-07T13:54:27Zurn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
Remove onion service descriptor-related errorkinds.2023-06-22T17:11:06ZNick Mathewsonnickm@torproject.org2023-06-22T17:11:06Zurn:sha1:33bfa7c7a86035342b09920cbf4c85e83889bb46
These have been subsumed by other errorkinds, mostly
OnionServiceProtocolViolation and TorProtocolViolation.
In particular please review the change in tor-hsclient closely;
I am not sure about the new errorkinds for the error there.
arti: Resolve TODO HS items related to extended SOCKS5 errors2023-06-22T15:05:57ZNick Mathewsonnickm@torproject.org2023-06-22T15:05:57Zurn:sha1:57b1e36667023d86cad36ddc846256abad602a9b
This takes an approach discussed in #736: Instead of trying to
distinguish INTRO/REND failures perfectly, we instead map our
existing ErrorKinds as best we can, in respect to the fact that
this distinction is not super important in practice.
Closes #736
New ErrorKind for invalid onion addresses2023-06-22T14:57:08ZNick Mathewsonnickm@torproject.org2023-06-22T14:51:52Zurn:sha1:967cae6cede19e7911ea2bed5f8e6f571c72d0b2
Use this to emit HS_BAD_ADDRESS as appropriate.
Remove ErrorKind::OnionService{Intro,Rend}Failed2023-06-22T14:56:23ZNick Mathewsonnickm@torproject.org2023-06-22T14:37:26Zurn:sha1:1a9e5b8463b3c0a10e558d67201499fea09d492b
These errors are orthogonal to our actual error kinds. See
discussion on #736.
Generate correct ErrorKinds for hsdesc decryption failures.2023-06-21T14:22:42ZNick Mathewsonnickm@torproject.org2023-06-21T14:17:43Zurn:sha1:dd944bc7874f6adc39814ac32e67ba7ccbd15394
Part of #736
Add and use ErrorKinds for remaining onion service errors2023-06-21T13:01:02ZNick Mathewsonnickm@torproject.org2023-06-16T16:58:26Zurn:sha1:2d7756956ed363c9c53d98618ec3a5e991af1359arti: return prop304 extended socks5 reply codes for onion services2023-06-21T13:01:01ZNick Mathewsonnickm@torproject.org2023-06-14T15:10:35Zurn:sha1:36c411260041f4927745f35aca2cf3fee3351ad4
We don't yet return all of them; this commit adds some todo notes
about changes we may need to our ErrorKinds.
Part of #736
arti: Abbreviate SocksStatus and ErrorKind imports and refactor.2023-06-21T13:00:03ZNick Mathewsonnickm@torproject.org2023-06-14T14:53:37Zurn:sha1:fbb3d98fb3f13610874a0280734d0c63be3f9068RPC: Suppress a warning to do with RPC and SOCKS2023-06-13T11:11:23ZIan Jacksonijackson@chiark.greenend.org.uk2023-06-13T11:09:11Zurn:sha1:5d49660e0ad6fc7d31cdaad3f51427c648d05b7b
Fixes `cargo check`