mirrors/arti.git/crates/arti/src/reload_cfg.rs, branch arti-v1.6.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.6.02025-05-29T14:21:17Z*: suppress cognitive_complexity warnings from nightly2025-05-29T14:21:17ZNick Mathewsonnickm@torproject.org2025-05-21T14:48:35Zurn:sha1:5327d3e22a83b8469a5d4191d92e1364344ddc93
Apparently clippy nightly is better (or worse?) about detecting
complex functions than before, so I'm suppressing these warnings
where they occur.
I have mixed feelings about these warnings: On the plus side,
they really do help to detect functions that are twistier than they
need to be. On the minus side, they get confused by tracing macros,
and the "allows" do pile up. But on the plus side, those "allows"
do provide a way to find functions that need to be refactored,
and they are never uglier than the functions they decorate.
arti: Disable RPC reconfiguration for now2024-12-19T21:12:25ZNick Mathewsonnickm@torproject.org2024-12-11T16:53:01Zurn:sha1:04bc3d2e0444c8a7112e813f20d83d58b279df45tor-config: Document the limitations of the FileWatcher.2024-10-16T15:59:27ZGabriela Moldovangabi@torproject.org2024-10-16T15:38:00Zurn:sha1:960ff90c2e595928389b2c8feaf2e052d7dc9f58arti: Temporarily disable a flaky test.2024-09-05T16:57:02ZIan Jacksonijackson@chiark.greenend.org.uk2024-09-05T16:56:27Zurn:sha1:9ca840b12bea42f8bfdd691a8b6208257ca3609b
This effectively reverts 71e3d52f5aeb34ca7bca80053079a8c7505b99ac,
which was itself a revert of disabling this test the first time.
Sadly it still doesn't seem to be reliable. We have agreed on IRC to
disable it for now.
Merge branch 'slow-test' into 'main'2024-09-05T10:39:48ZIan Jacksoniwj@torproject.org2024-09-05T10:39:48Zurn:sha1:30cb69520890b7a85f436de0d40dfa95ef0c95d8
arti: Make the config watcher debounce interval configurable.
Closes #1589
See merge request tpo/core/arti!2387arti: Make the config watcher debounce interval configurable (fmt).2024-09-04T13:13:42ZGabriela Moldovangabi@torproject.org2024-09-04T13:10:43Zurn:sha1:d952b2bd75135c95d8400da49f81439c0d36e79farti: Make the config watcher debounce interval configurable.2024-09-04T13:13:32ZGabriela Moldovangabi@torproject.org2024-09-04T13:07:16Zurn:sha1:15ade3cd9be04c81200681b32fedd042bf515072
Previously, the `reload_cfg::test::watch_multiple` test would take about
3s to run. This test modifies 3 files and waits for the corresponding
`reconfigure()` events to fire. Because of the
`sleep(DEBOUNCE_INTERVAL)` in `run_watcher`, it would wind up waiting
for about 1s for each of them.
This makes the event debouncing optional, and disables it in the tests.
Closes #1589
Revert "arti: Temporarily disable a flaky test."2024-08-29T09:12:52ZGabriela Moldovangabi@torproject.org2024-08-28T17:59:05Zurn:sha1:71e3d52f5aeb34ca7bca80053079a8c7505b99ac
This reverts commit ececf6be2eaffc201666cd3413dc19c025be66de.
arti: Write the test config atomically.2024-08-29T09:12:48ZGabriela Moldovangabi@torproject.org2024-08-28T17:55:31Zurn:sha1:45f2c61d205c4ea3a232254d069503a8875f5c29
The flakiness from the `watch_single_file` test was caused by the race
between the config write, and the fake SIGHUP "signal" sent on
`sighup_tx`: sometimes, the sighup would get handled between creating
the config file and writing its contents. In those cases, the config
received in `TestModule::reconfigure` would be `Default::default()`,
which caused an assertion to fail (because the test is expecting to
receive the `ArtiConfig` it wrote to disk).
Closes #1549
tor-config: Rename watch_file to watch_path.2024-08-27T13:35:30ZGabriela Moldovangabi@torproject.org2024-08-27T11:30:19Zurn:sha1:5619aa0ed22a2421defa53189564baea24a0bf16
`FileWatcher::watch_file` can be used with arbitrary paths.