mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.1 2024-03-13T13:38:22Z 2024-03-13T13:38:22Z Nick Mathewson nickm@torproject.org 2024-02-15T15:22:43Z urn:sha1:969e037edf422a6a574f3367d4784e2864d1c8a8 This will let us test our configuration logic without having to use the `config` crate directly. 2024-03-04T11:08:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-03-04T11:08:36Z urn:sha1:817a586d0275c64d3e54de6b3cff82d54ab76702 That seems often how we do things elsewhere. 2024-03-04T11:02:17Z Ian Jackson ijackson@chiark.greenend.org.uk 2024-03-04T11:02:17Z urn:sha1:7ec3d1ed9b37b3326abe28cd3fdadb99668aedc0 I found this confusing in !2009, where the variable is unused on Windows: I wondered if this meant our config-reloading only worked on Unix, since "obviously it would need the TorClient". But actually the TorClient was only used *in this argument* for its runtime. The actual reconfiguration of the TorClient is doen by it being in one of the ReconfigurableModule's. Change the type of the argument for clarity. 2024-02-29T22:40:32Z Tobias Stoeckmann tobias@stoeckmann.org 2024-02-29T22:26:34Z urn:sha1:d7a90cec007c9208de383b9d925559756e2c9805 Do not complain on non-unix systems that variable client is not used. It is only accessed within the function on unix systems. 2024-01-25T13:58:49Z Gabriela Moldovan gabi@torproject.org 2024-01-25T13:58:49Z urn:sha1:fa7a9440d4978f2348bfe1bd6620b3c084322c98 Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1917#note_2988815 2024-01-25T12:25:45Z Gabriela Moldovan gabi@torproject.org 2024-01-25T11:47:18Z urn:sha1:81c0dccf8f38b7d7fe77d683d7210f88fb4161db Previously, the `ProxySet` (and all the other `reconfigurable_modules`) were kept alive by the `watch_for_config_changes` background thread, which was preventing them from being dropped when `run()` exited. IOW, onion services never received the shutdown signal. Now `watch_for_config_changes` takes `Weak` references, and the only strong references to the modules are kept in the `reconfigurable_modules` local variable in `run()`, which is dropped when `run()` exits (e.g. on SIGINT). This allows onion services to execute their shutdown logic on CTRL-C. Part of #1244 2023-12-12T19:50:26Z Nick Mathewson nickm@torproject.org 2023-12-11T16:28:39Z urn:sha1:58d11981035d4e359109ef8fb0b1101f1f867736 It's correct that we'd like someday for the `arti` crate APIs to allow all the different modes supported by `Reconfigure` enum; this is #1156, and it does not block an HSS release. 2023-12-05T17:45:51Z Nick Mathewson nickm@torproject.org 2023-12-05T17:45:51Z urn:sha1:1ac515c183bf8c1d7e07bccd0fdbd3644041b250 Now instead of having a hardwired list of of things to reconfigure, the watch_cfg module now has a vector of ReconfigurableModule. As noted in the documentation, I don't intend that this should be our final API here: It is deliberately not exposed. When we revisit the structure of `arti` more, we should probably do this differently. 2023-09-06T02:34:56Z Nick Mathewson nickm@torproject.org 2023-08-30T18:43:38Z urn:sha1:8b8faacd1cbcdd841a02cd0273f75377d5a91b3f I have no idea why these became necessary. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949.