mirrors/arti.git/crates/arti/src/reload_cfg.rs, branch arti-v1.1.13mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.132024-01-25T13:58:49Zarti: Only exit if all the modules have been dropped.2024-01-25T13:58:49ZGabriela Moldovangabi@torproject.org2024-01-25T13:58:49Zurn:sha1:fa7a9440d4978f2348bfe1bd6620b3c084322c98
Prompted by https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/1917#note_2988815
arti: Use Weak references for the reconfigurable modules.2024-01-25T12:25:45ZGabriela Moldovangabi@torproject.org2024-01-25T11:47:18Zurn:sha1:81c0dccf8f38b7d7fe77d683d7210f88fb4161db
Previously, the `ProxySet` (and all the other `reconfigurable_modules`)
were kept alive by the `watch_for_config_changes` background thread,
which was preventing them from being dropped when `run()` exited. IOW,
onion services never received the shutdown signal.
Now `watch_for_config_changes` takes `Weak` references, and the only
strong references to the modules are kept in the
`reconfigurable_modules` local variable in `run()`, which is dropped
when `run()` exits (e.g. on SIGINT). This allows onion services to
execute their shutdown logic on CTRL-C.
Part of #1244
arti: Generalize a TODO HSS about reconfiguration.2023-12-12T19:50:26ZNick Mathewsonnickm@torproject.org2023-12-11T16:28:39Zurn:sha1:58d11981035d4e359109ef8fb0b1101f1f867736
It's correct that we'd like someday for the `arti` crate APIs to
allow all the different modes supported by `Reconfigure` enum;
this is #1156, and it does not block an HSS release.
arti: Make reconfiguration slightly more abstract2023-12-05T17:45:51ZNick Mathewsonnickm@torproject.org2023-12-05T17:45:51Zurn:sha1:1ac515c183bf8c1d7e07bccd0fdbd3644041b250
Now instead of having a hardwired list of of things to reconfigure,
the watch_cfg module now has a vector of ReconfigurableModule.
As noted in the documentation, I don't intend that this should be
our final API here: It is deliberately not exposed. When we revisit
the structure of `arti` more, we should probably do this
differently.
Add cognitive-complexity exceptions for clippy.2023-09-06T02:34:56ZNick Mathewsonnickm@torproject.org2023-08-30T18:43:38Zurn:sha1:8b8faacd1cbcdd841a02cd0273f75377d5a91b3f
I have no idea why these became necessary.
Throughout: Use *_report!() macros for reporting Errors.2023-07-07T17:00:21ZNick Mathewsonnickm@torproject.org2023-07-07T13:54:27Zurn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
Corrected the order of imports in order to make the 'rust-checks' job complete successfully.2023-06-22T23:25:28ZAndyandy@andy.codes2023-06-22T23:25:28Zurn:sha1:3105f99a9905c445f31040d9dcdb3ac5bd999edfProvided a fix for #831 - 'Unused import' warnings on Windows2023-06-22T23:11:20ZAndyandy@andy.codes2023-06-22T23:11:20Zurn:sha1:bec24f792050186bddd63ec837bca12c956c7a71Use tor_error::Report for remaining errors in error! in arti2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:37:42Zurn:sha1:22016f233b5a8e277c15e1512f8f22a81f4ab537Use ErrorReport/Report for errors in warn! in arti2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:10:00Zurn:sha1:36ebf7d23adcf727972abd97d0a768be86c0e5a5