mirrors/arti.git/crates/arti/src/logging.rs, branch ios-sqlite-hacks mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=ios-sqlite-hacks 2023-07-07T17:00:21Z Throughout: Use *_report!() macros for reporting Errors. 2023-07-07T17:00:21Z Nick Mathewson nickm@torproject.org 2023-07-07T13:54:27Z urn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9 I identified the cases to replace by searching for the string `.report()`. There are a few that I didn't change: * A couple of cases that used anyhow::Error, * One case that reported two Errors. * Two cases in `tor_hsclient::err` that just did `error!("Bug: {}")`. I have also not audited the cases in `tor-hsclient` where we're using `tor_error::Report` manually. Nonetheless, closes #949. Merge branch 'log_precision' into 'main' 2023-07-06T14:37:49Z Nick Mathewson nickm@torproject.org 2023-07-06T14:37:49Z urn:sha1:36a92e44d9a36afa1c9b88caa1505e38ae5d5cc5 arti: Add a `logging.time_granularity` option with 1s default. Closes #551 See merge request tpo/core/arti!1376 arti: Add a `logging.time_granularity` option with 1s default. 2023-07-06T13:44:09Z Nick Mathewson nickm@torproject.org 2023-07-05T17:09:20Z urn:sha1:512064cc19d24c111495150f8cf424b89395847b This lets us provide less information in our logs: in particular, it lets us avoid logging with microsecond precision. Closes #551. arti: Note possibility for future use of other tracing panic provider 2023-07-06T12:50:53Z Nick Mathewson nickm@torproject.org 2023-07-06T12:50:53Z urn:sha1:d2b6fee3f99bcec0252e5efd182ccde90ea900c8 arti: On panic, avoid allocation even more. 2023-07-06T12:45:34Z Nick Mathewson nickm@torproject.org 2023-07-06T12:45:34Z urn:sha1:01f1192b20267038817e410dab31ca1acdb64f73 The original version of our panic handler would allocate a string for the panic `Location`. But if we're panicking we'd like to keep allocations to a minimum: so instead format the `Location` conditionally. This also drops a useless `std::borrow::Cow`. (The possibility of a "Don't have a `Cow`" commit message was considered and rejected.) Add TODO comments about possibly migrating away from the backtrace crate. 2023-07-05T20:39:11Z Nick Mathewson nickm@torproject.org 2023-07-05T20:39:11Z urn:sha1:afa51fd5ca3c625fbe71e5991e38d8056427d282 arti: Install a panic hook that sends messages to `tracing` 2023-07-05T20:37:10Z Nick Mathewson nickm@torproject.org 2023-07-05T20:11:04Z urn:sha1:9c4de185e99b443558bd5a1b676579632ea26e6c (Also leaves installed the default handler that sends messages to stderr.) Closes #921. Use ErrorReport/Report for errors in warn! in arti 2023-01-30T18:52:32Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-01-30T18:10:00Z urn:sha1:36ebf7d23adcf727972abd97d0a768be86c0e5a5 Enforce SafeLogging on the console. 2022-09-26T15:36:18Z Nick Mathewson nickm@torproject.org 2022-09-26T15:36:18Z urn:sha1:8ddc1a4b3657d8073830ae4ade6f70b1f120cded Previously we always assumed that the console was ephemeral, and so we disabled safe logging. But the console can be piped to journald. And even if we enforce isatty there's no guarantee that the user isn't using some kind of terminal that logs to disk or something. Best just to enable SafeLogging unconditionally. I've added a note about where and how we might re-enable this. Closes #553. Mark a few APIs as experimental in docs. 2022-08-30T21:48:50Z Nick Mathewson nickm@torproject.org 2022-08-30T21:48:50Z urn:sha1:a07c4124b1d370b64f3e955a37a532023fc294ad For example, see https://tpo.pages.torproject.net/core/doc/rust/arti/fn.run.html : this isn't labeled as `experimental-api`, but it should be. These APIs were found by poking around in the `arti` crate.