mirrors/arti.git/crates/arti/src/logging.rs, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02024-02-22T18:33:52Zarti: Don't output ANSI escape codes when logging to file.2024-02-22T18:33:52ZGabriela Moldovangabi@torproject.org2024-02-22T18:33:52Zurn:sha1:1b0cd20a52c80136ce3ced14e17e6689aac8646f
Closes #1298
educe: Use std's default for enums where default variant is unit2024-02-12T11:38:36ZIan Jacksonijackson@chiark.greenend.org.uk2024-02-12T11:07:42Zurn:sha1:c35c60f848154e80f23ba95a989ff2f9d2594e6a
Since Rust 1.66, std's default works properly for enums, provided that
the default variant is a unit.
Review all uses of `#[educe(default)]` on enums and replace them with
std where possible, which is most of them.
In 1.66 and later, std's `#[derive(Default)]` doesn't infer any
generic bounds on the derived impl, where it's an enum - since the
unit variant can always be constructed. So this change doesn't add
any generic bounds and is not API-visible.
Throughout: Use *_report!() macros for reporting Errors.2023-07-07T17:00:21ZNick Mathewsonnickm@torproject.org2023-07-07T13:54:27Zurn:sha1:25c6fe61e4cf230210dffdac2d3c281fcb31c5a9
I identified the cases to replace by searching for the string
`.report()`. There are a few that I didn't change:
* A couple of cases that used anyhow::Error,
* One case that reported two Errors.
* Two cases in `tor_hsclient::err` that just did
`error!("Bug: {}")`.
I have also not audited the cases in `tor-hsclient` where we're using
`tor_error::Report` manually.
Nonetheless, closes #949.
Merge branch 'log_precision' into 'main'2023-07-06T14:37:49ZNick Mathewsonnickm@torproject.org2023-07-06T14:37:49Zurn:sha1:36a92e44d9a36afa1c9b88caa1505e38ae5d5cc5
arti: Add a `logging.time_granularity` option with 1s default.
Closes #551
See merge request tpo/core/arti!1376arti: Add a `logging.time_granularity` option with 1s default.2023-07-06T13:44:09ZNick Mathewsonnickm@torproject.org2023-07-05T17:09:20Zurn:sha1:512064cc19d24c111495150f8cf424b89395847b
This lets us provide less information in our logs: in particular, it
lets us avoid logging with microsecond precision.
Closes #551.
arti: Note possibility for future use of other tracing panic provider2023-07-06T12:50:53ZNick Mathewsonnickm@torproject.org2023-07-06T12:50:53Zurn:sha1:d2b6fee3f99bcec0252e5efd182ccde90ea900c8arti: On panic, avoid allocation even more.2023-07-06T12:45:34ZNick Mathewsonnickm@torproject.org2023-07-06T12:45:34Zurn:sha1:01f1192b20267038817e410dab31ca1acdb64f73
The original version of our panic handler would allocate a string
for the panic `Location`. But if we're panicking we'd like to keep
allocations to a minimum: so instead format the `Location`
conditionally.
This also drops a useless `std::borrow::Cow`. (The possibility of a
"Don't have a `Cow`" commit message was considered and rejected.)
Add TODO comments about possibly migrating away from the backtrace crate.2023-07-05T20:39:11ZNick Mathewsonnickm@torproject.org2023-07-05T20:39:11Zurn:sha1:afa51fd5ca3c625fbe71e5991e38d8056427d282arti: Install a panic hook that sends messages to `tracing`2023-07-05T20:37:10ZNick Mathewsonnickm@torproject.org2023-07-05T20:11:04Zurn:sha1:9c4de185e99b443558bd5a1b676579632ea26e6c
(Also leaves installed the default handler that sends messages to
stderr.)
Closes #921.
Use ErrorReport/Report for errors in warn! in arti2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:10:00Zurn:sha1:36ebf7d23adcf727972abd97d0a768be86c0e5a5