mirrors/arti.git/crates/arti/src/logging.rs, branch arti-v1.1.6mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.62023-01-30T18:52:32ZUse ErrorReport/Report for errors in warn! in arti2023-01-30T18:52:32ZIan Jacksonijackson@chiark.greenend.org.uk2023-01-30T18:10:00Zurn:sha1:36ebf7d23adcf727972abd97d0a768be86c0e5a5Enforce SafeLogging on the console.2022-09-26T15:36:18ZNick Mathewsonnickm@torproject.org2022-09-26T15:36:18Zurn:sha1:8ddc1a4b3657d8073830ae4ade6f70b1f120cded
Previously we always assumed that the console was ephemeral, and so
we disabled safe logging. But the console can be piped to journald.
And even if we enforce isatty there's no guarantee that the user
isn't using some kind of terminal that logs to disk or something.
Best just to enable SafeLogging unconditionally. I've added a note
about where and how we might re-enable this.
Closes #553.
Mark a few APIs as experimental in docs.2022-08-30T21:48:50ZNick Mathewsonnickm@torproject.org2022-08-30T21:48:50Zurn:sha1:a07c4124b1d370b64f3e955a37a532023fc294ad
For example, see
https://tpo.pages.torproject.net/core/doc/rust/arti/fn.run.html :
this isn't labeled as `experimental-api`, but it should be.
These APIs were found by poking around in the `arti` crate.
arti: Raise the default console log severity to "info"2022-08-25T13:10:42ZNick Mathewsonnickm@torproject.org2022-08-25T13:10:42Zurn:sha1:8fa1568b02a3cd4101f65b0e224151cb9813d0bc
Previously we logged at "debug", but that's not meant to
user-facing.
arti: Move most public APIs behind `experimental-api`.2022-08-11T19:35:32ZNick Mathewsonnickm@torproject.org2022-08-08T14:14:30Zurn:sha1:f548a6ac55b5f1feb92ea4ffe5c4882a2e19a739
The remaining unconditionally public APIs are those related to our
configuration objects, and the main_main() API.
The rationale for making main_main() public is to have an actual
entry point.
The rationale for making the config APIs public is:
1. We really do intend for others to be able to read our
configuration files using this API.
2. The structure of our configuration files is already part of our
interface.
Closes #530.
impl_standard_builder: Use for arti::logging::LogfileConfig2022-06-16T14:42:06ZIan Jacksonijackson@chiark.greenend.org.uk2022-06-16T14:13:31Zurn:sha1:c466f13ce35a1f64e17774dbbde195600f09ba83arti: logging config: Replace a manual Debug impl2022-06-16T14:27:00ZIan Jacksonijackson@chiark.greenend.org.uk2022-06-16T13:53:03Zurn:sha1:c5bbaf470ac992d2af29b3ad60358575b3a34c27config: Do not strip_option for journald (and in future)2022-06-10T13:23:13ZIan Jacksonijackson@chiark.greenend.org.uk2022-06-10T13:22:05Zurn:sha1:77f33176c31c770aea5e1cdb97d0dbe57f89e674
As per point 1 in
https://gitlab.torproject.org/tpo/core/arti/-/issues/488
config: Provide tor_config::resolve_option and resolve journald2022-05-30T15:00:45ZIan Jacksonijackson@chiark.greenend.org.uk2022-05-27T11:44:04Zurn:sha1:fbfaecdf72be9db7998cf5351351fa8112cef1f4
Canonicalise the `logging.journald` setting in the validated
configuration. Now it will never be `Some("")`, even if that is what
was written in the config file.
This allows us to write `journald = ""` in the example configuration.
(Without the canonicalisation the default builder produces `None` and
the example would produce `Some("")`, which are semantically identical
but fail the test.)
See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some
background.
Apply fs-mistrust to logfile directories.2022-05-24T14:54:02ZNick Mathewsonnickm@torproject.org2022-05-23T15:43:28Zurn:sha1:25c64db575cc5f8426c026b29cb82ff7fa270c43