mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.4.0 2022-05-24T14:54:02Z 2022-05-24T14:54:02Z Nick Mathewson nickm@torproject.org 2022-05-23T15:43:28Z urn:sha1:25c64db575cc5f8426c026b29cb82ff7fa270c43 2022-05-12T17:50:26Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T17:15:39Z urn:sha1:be5bc04c02d5023c46a117a048bf0a659094f4eb This deletes many handcoded impls. It also generates lots of impls that we previously didn't have. 2022-05-12T14:59:13Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:58:58Z urn:sha1:c1c6f2b376827c4ebb13bc08456f8355717d15e5 I have Plans for this macro. In particular: * I have a wip branch which tests that the Builder can be deserialised from an empty config (ie, that config reading of a config with a blank section for this item works). * I think we should autogenerate $Config::builder(), and promote that, rather than $ConfigBuilder::default(). This macro could do that. 2022-05-12T14:59:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-12T14:35:44Z urn:sha1:888d6e0511d01379d42ae154ac99ce2d9e84fd44 2022-05-06T11:38:16Z Nick Mathewson nickm@torproject.org 2022-05-04T13:21:40Z urn:sha1:b879125668db7416ba527793fe56e4a50a00436a 2022-05-06T11:38:14Z Nick Mathewson nickm@torproject.org 2022-05-04T13:13:29Z urn:sha1:7e34692a65c02dbcf2bb1cd330ab9665a017d52e Here we add a config option to disable safe logging, and ensure that safe logging is disabled when we are formatting an error message on exit (since we assume it's safe to write sensitive info to stderr.) 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-05T09:19:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T17:41:35Z urn:sha1:2c1282f537ef89389e537e849ee906cc53d0f811 We want to be able to serialise as well as deserialise configurations. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-04-25T17:22:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T16:38:40Z urn:sha1:ce877e442124cb61a38ffe4ab7b3f29ff1b3541f And add an imprecation in define_list_config_builder's doc comment do do so in future for other invocations of the macro. Add add the missing full stops.