mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.3.0 2022-05-06T11:38:16Z 2022-05-06T11:38:16Z Nick Mathewson nickm@torproject.org 2022-05-04T13:21:40Z urn:sha1:b879125668db7416ba527793fe56e4a50a00436a 2022-05-06T11:38:14Z Nick Mathewson nickm@torproject.org 2022-05-04T13:13:29Z urn:sha1:7e34692a65c02dbcf2bb1cd330ab9665a017d52e Here we add a config option to disable safe logging, and ensure that safe logging is disabled when we are formatting an error message on exit (since we assume it's safe to write sensitive info to stderr.) 2022-05-05T09:35:52Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T16:45:25Z urn:sha1:d47e94b45993162fece0d1bdfa4d3da0407a4861 * Builders additionally derive: Debug, Serialize, Deserialize. * Validated structs no longer derive: Serialize, Deserialize and all related attributes deleted. * As a consequence, all the `#[serde(deny_unknown_fields)]` are gone. That means that right now unknown fields are totally ignored. This is good for compatibility but poor for useability. Doing something better here is arti#417, in progress. * As a consequence, delete tor_dirmgr::retry::default_parallelism. (The default value was already duplicated into a builder attr.) 2022-05-05T09:19:29Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T17:41:35Z urn:sha1:2c1282f537ef89389e537e849ee906cc53d0f811 We want to be able to serialise as well as deserialise configurations. 2022-05-04T12:50:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-04T12:32:35Z urn:sha1:4bca91271558d950092fb1ac51c1316655d293cb The new API is (roughly) as discussed in https://gitlab.torproject.org/tpo/core/arti/-/issues/451 This is quite a large commit and it is not convenient to split it up. It contains the following changes: * Redo the list builder and accessor macros implemnetation, including docs and tests. * Change uses of define_list_config_builder. In each case: - Move the docs about the default value to the containing field. - Remove the other docs (which were just recapitulations, and are now not needed since the ListBuilder is no longer public). - Rewmove or replace `pub` in the define_list_builder_helper call, so that the builder is no longer public. - Change the main macro call site to use define_list_builder_helper. - Add a call to define_list_builder_accessors. * Make the module `list_builder` pub so that we have somewhere to put the overview documentation. * Consequential changes: - Change `outer.inner().replace(X)` to `outer.set_inner(X)` - Consequential changes to imports (`use` statements). 2022-04-25T17:22:54Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T16:38:40Z urn:sha1:ce877e442124cb61a38ffe4ab7b3f29ff1b3541f And add an imprecation in define_list_config_builder's doc comment do do so in future for other invocations of the macro. Add add the missing full stops. 2022-04-25T16:05:30Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T15:49:42Z urn:sha1:dca4f3ede107ec343e733f580723140437cc8c7f As per https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/471#note_2798020 2022-04-25T11:41:00Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T10:39:24Z urn:sha1:0036b916622e9371e3788f1ac34e30efc2ba7da4 This replaces two almost-identical sets of structs and impls. More are on the way, as per https://gitlab.torproject.org/tpo/core/arti/-/issues/447 2022-04-25T11:38:36Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-25T10:29:33Z urn:sha1:62aa0719989a96722cde7d34c4d103220881569f Since "logfiles: Introduce LogfileListConfigBuilder", this code is in LogfileListConfigBuilder::build(), which is called by derive_builder's generated LoggingConfig::build(), and which will add a file context itself due to the `sub_builder` feature. So this is otiose. And, we are about to replace this whole thing with macro_rules-generated code (which won't do this). 2022-04-22T16:48:03Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-04-22T16:39:42Z urn:sha1:79decd4ac8194fe3e14d7b755201dac13f50050f In https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/462#note_2797697 we decided not to do this. However, having looked again at the way the FallbackList works, I think there is a lot of value in making these two things (and anything else like them[1]) as similar as possible. [1] At least PreemptiveCircuitConfig.initial_predicted_ports and NetworkConfig.authorities need the same treatment, and perhaps also GuardUsage.restrictions (although there is no GuardRestrictionBuilder). In the irc discussion I imagined `LogfilesConfigBuilder` as opposed to `LogfileConfigBuilder` (differing only in the `s`) which would be bad, but we can use `List` instead. We do *not* need to abstract away the validated version of the config. Providing a type alias helps the derive_builder sub_builder DTRT without needing special overrides. I have split this commit so that we can drop it, if we conclude it's not wanted.