mirrors/arti.git/crates/arti/src/lib.rs, branch tor-circmgr-v0.18.1mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=tor-circmgr-v0.18.12024-04-22T15:25:45ZUpgrade to futures-rustls 0.26.0, rustls 0.23.5.2024-04-22T15:25:45ZNick Mathewsonnickm@torproject.org2024-04-22T14:00:46Zurn:sha1:5f035cb5cbcb11bcdf0467667ad51a53bcdbce85
The rustls upgrade will solve #1377 and CVE-2024-32650.
Note that we've had to patch our RustlsProvider impl a bit in order
to keep the tests passing. See comments.
Closes #1377.
arti, CI: Add a test case for command line help2024-03-05T18:26:05ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T18:32:51Zurn:sha1:b8679040a9c69367a810c44765b77b57ed75af8farti: Print help on `arti hss` without subcommand2024-03-05T18:26:05ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T18:00:20Zurn:sha1:108c8e76bd3829e565fd1d6fe44133229240d9b3
That's not the default.
arti: Fix misplaced clap hunk2024-03-05T18:26:05ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T17:57:20Zurn:sha1:f8fe62b61cf08acf4c260aacaeddef5a83772140
ab950a68 "arti: Add an hss subcommand." mistakenly moved the calls to
`subcommand_required` and `arg_required_else_help` into the
compile-time conditional. But they're related to the main command
parsing.
Fixes #1311
Merge branch 'deny-unchecked-duration-substraction' into 'main'2024-03-05T11:13:28ZIan Jacksoniwj@torproject.org2024-03-05T11:13:28Zurn:sha1:1f5429910db62912163e31d49451031059cad788
deny clippy::unchecked_duration_subtraction
Closes #1304
See merge request tpo/core/arti!2008arti config watch: Pass Runtime as first argument2024-03-04T11:08:36ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T11:08:36Zurn:sha1:817a586d0275c64d3e54de6b3cff82d54ab76702
That seems often how we do things elsewhere.
arti config watch: Pass a Runtime, not a TorClient (fmt)2024-03-04T11:08:12ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T11:08:12Zurn:sha1:ca5501149acd1d8047fa69c701900ced6efc4666arti config watch: Pass a Runtime, not a TorClient2024-03-04T11:02:17ZIan Jacksonijackson@chiark.greenend.org.uk2024-03-04T11:02:17Zurn:sha1:7ec3d1ed9b37b3326abe28cd3fdadb99668aedc0
I found this confusing in !2009, where the variable is unused on
Windows: I wondered if this meant our config-reloading only worked on
Unix, since "obviously it would need the TorClient".
But actually the TorClient was only used *in this argument* for its
runtime. The actual reconfiguration of the TorClient is doen by it
being in one of the ReconfigurableModule's.
Change the type of the argument for clarity.
deny clippy::unchecked_duration_subtraction2024-02-29T17:16:49Ztrinity-1686atrinity@deuxfleurs.fr2024-02-29T17:06:46Zurn:sha1:ac5b36027ca825d27ef466501c660ce498fd9e3cRefactor and improve error hinting.2024-02-14T18:29:26ZNick Mathewsonnickm@torproject.org2024-02-14T17:10:51Zurn:sha1:33c33380a7e4a949d83844814025b921a2b3ce9b
Instead of using complicated match statements, use downcasting
to find error types that define specific hints. This also lets us
define a reasonable hint-extractor for anyhow::Error, and use it
when reporting errors in main.
I've left an implementation of hint() in `impl Error`, to
avoid breaking backward compatibility.
Closes #1165.