mirrors/arti.git/crates/arti/src/lib.rs, branch arti-v1.2.0mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.02024-02-14T18:29:26ZRefactor and improve error hinting.2024-02-14T18:29:26ZNick Mathewsonnickm@torproject.org2024-02-14T17:10:51Zurn:sha1:33c33380a7e4a949d83844814025b921a2b3ce9b
Instead of using complicated match statements, use downcasting
to find error types that define specific hints. This also lets us
define a reasonable hint-extractor for anyhow::Error, and use it
when reporting errors in main.
I've left an implementation of hint() in `impl Error`, to
avoid breaking backward compatibility.
Closes #1165.
arti: Use Weak references for the reconfigurable modules (fmt).2024-01-25T12:25:53ZGabriela Moldovangabi@torproject.org2024-01-25T12:24:36Zurn:sha1:9b714714db649dec900f9931d29ee0965f9349abarti: Use Weak references for the reconfigurable modules.2024-01-25T12:25:45ZGabriela Moldovangabi@torproject.org2024-01-25T11:47:18Zurn:sha1:81c0dccf8f38b7d7fe77d683d7210f88fb4161db
Previously, the `ProxySet` (and all the other `reconfigurable_modules`)
were kept alive by the `watch_for_config_changes` background thread,
which was preventing them from being dropped when `run()` exited. IOW,
onion services never received the shutdown signal.
Now `watch_for_config_changes` takes `Weak` references, and the only
strong references to the modules are kept in the
`reconfigurable_modules` local variable in `run()`, which is dropped
when `run()` exits (e.g. on SIGINT). This allows onion services to
execute their shutdown logic on CTRL-C.
Part of #1244
tor-hsservice: Add TODO about testing arti hss.2024-01-18T10:21:46ZGabriela Moldovangabi@torproject.org2024-01-17T13:58:11Zurn:sha1:8f5c2f7e2c6f3e268d32f81ba86c0b32b6c0dc24arti: Use OnionService to get the onion_name().2024-01-18T10:21:46ZGabriela Moldovangabi@torproject.org2024-01-16T17:29:35Zurn:sha1:c70d9ec6b557aee309e3d6720fae186b8c7ad52eGive an error when user configured onion services with no support.2024-01-16T16:42:27ZNick Mathewsonnickm@torproject.org2024-01-16T16:42:27Zurn:sha1:bbca0da490059cb757c51d3367f6ab75a397ca09
We do this by adding a stub config and config builder type, whose
only purpose is to generate an error if anything is deserialized
into it.
(If this turns out not to be the best pattern, we can change it
later, since this is all internal to the `arti` crate.)
Closes #1184.
tor-keymgr: Abolish ArtiNativeKeystoreConfig::expand_keystore_dir.2024-01-10T15:07:26ZGabriela Moldovangabi@torproject.org2024-01-10T15:03:25Zurn:sha1:0f6d98bcb26707a89385975ea3177d56ab08ab4a
This resolves a `TODO HSS` in arti-client.
Part of #1187
arti::lib: Downgrade "TODO HSS" comments2024-01-09T19:30:26ZNick Mathewsonnickm@torproject.org2024-01-09T19:30:26Zurn:sha1:b4a0714d4ad0aed2102c13d0163a96c95a051b61
These are not "must fix before releasing onion services".
arti: Fix log message typo.2023-12-14T18:33:19ZGabriela Moldovangabi@torproject.org2023-12-14T16:46:06Zurn:sha1:d8d83a1543164fd609e2af81aac9e57f4b9581ecMerge branch 'return-of-the-son-of-arti-todos' into 'main'2023-12-14T16:30:44ZNick Mathewsonnickm@torproject.org2023-12-14T16:30:44Zurn:sha1:1527b6dc386703f9e2765413c0fbe9a00ef7e5e5
Resolve Arti crate todos, redux
See merge request tpo/core/arti!1833