mirrors/arti.git/crates/arti/src/cfg.rs, branch arti-v0.5.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v0.5.0 2022-06-16T15:08:10Z arti: cfg: Remove another needless borrow 2022-06-16T15:08:10Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-16T15:08:10Z urn:sha1:ed62a575d33167595f62341bd715ce1278f2fccf arti cfg tests: Remove a redundant line that shadows an earlier binding 2022-06-16T13:34:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-16T13:31:14Z urn:sha1:fc3f36e9c928a3b6265cf2dece1edc2a1eb1e119 Prompted by review https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/589#note_2813596 arti cfg tests: Test that example config works as-is 2022-06-16T13:34:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-15T16:01:00Z urn:sha1:1332e02b61c07e491a9704ee8fcdb61a40ece3ce It contains only sections, but we want to detect when that is a problem! arti: cfg tests: Refactor to prepare for new test 2022-06-16T13:34:43Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-06-15T16:00:19Z urn:sha1:0ab60d832a25920bc9020d3262ace340d557cb3e We're going to call this new closure another time. arti config: Check that example config is exhaustive 2022-05-30T15:03:01Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-26T14:08:47Z urn:sha1:fe9fb6b6ee94a1e450d4b4b019aa5658647b788f This is the final piece of #457. arti: config: Canonicalise ports, and provide example dns_port 2022-05-30T15:00:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-27T12:06:53Z urn:sha1:ca60859dffc3c809ecf5e75d5fca17f36b75c0d8 Now the validated configuration will never be `Some(0)`, even if that is what was written in the config file. The arti CLI parser can still produce this, so we don't touch the code that actually uses this. (Without the canonicalisation the default builder produces `None` for the `dns_port`, but the example would produce `Some(0)`, which is semantically identical but fails the test.) See https://gitlab.torproject.org/tpo/core/arti/-/issues/488 for some background. arti: Make ProxyConfig no longer Deserialize 2022-05-30T15:00:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-27T11:46:25Z urn:sha1:c8d5681ff12dec80fec9133cd09a6eef7d631d7b That this remained was an oversight. arti: cfg: Actually uncomment *all* the things in the example 2022-05-30T15:00:45Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-26T14:11:57Z urn:sha1:e0d9d2434833b324fa2ff93f98b1951ac291fe54 add unit tests for ArtiConfig public functions 2022-05-29T00:41:31Z michael mccune msm@opbstudios.com 2022-05-29T00:41:31Z urn:sha1:db6842f666150b4091acc14560268311cfdcca07 this change adds some simple tests for the ArtiConfig public getter functions to help expand coverage in this crate. arti: Better doc for ArtiCombinedConfig 2022-05-25T18:15:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2022-05-25T17:46:29Z urn:sha1:80ddae3d4b8669d614ed013acae01b19c266dc4d