mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.6 2023-06-30T12:42:21Z 2023-06-30T12:42:21Z Nick Mathewson nickm@torproject.org 2023-06-30T12:42:21Z urn:sha1:de13a7319b7de5a336a70f128d1904954ed77f82 Done with the commands below. The following crates have had various changes, and should get a patchlevel bump. Since they are pre-1.0, we do not need to distinguish new APIs from other changes. ``` cargo set-version --bump patch -p arti-client cargo set-version --bump patch -p safelog cargo set-version --bump patch -p tor-bytes cargo set-version --bump patch -p tor-cert cargo set-version --bump patch -p tor-circmgr cargo set-version --bump patch -p tor-config cargo set-version --bump patch -p tor-consdiff cargo set-version --bump patch -p tor-dirclient cargo set-version --bump patch -p tor-dirmgr cargo set-version --bump patch -p tor-error cargo set-version --bump patch -p tor-hsservice cargo set-version --bump patch -p tor-linkspec cargo set-version --bump patch -p tor-llcrypto cargo set-version --bump patch -p tor-netdir cargo set-version --bump patch -p tor-netdoc cargo set-version --bump patch -p tor-proto cargo set-version --bump patch -p tor-rpcbase cargo set-version --bump patch -p tor-socksproto ``` This crate has new features, but no new non-experimental Rust APIs. So even though it is post-1.0, it gets a patchlevel bump. ``` cargo set-version --bump patch -p arti ``` 2023-06-30T12:38:16Z Nick Mathewson nickm@torproject.org 2023-06-30T12:38:16Z urn:sha1:65e81bf0ca876669a15943caf4cf388515366623 Done with: ``` cargo set-version --bump minor -p tor-hsclient cargo set-version --bump minor -p arti-rpcserver cargo set-version --bump minor -p tor-hscrypto cargo set-version --bump minor -p tor-cell ``` 2023-06-29T21:09:52Z Nick Mathewson nickm@torproject.org 2023-06-29T21:09:52Z urn:sha1:23c67d92e62f46629807c1c681267374b2dcd72e 2023-06-29T17:09:37Z Nick Mathewson nickm@torproject.org 2023-06-29T17:09:37Z urn:sha1:d164a9dac216536bf960c7cb6a1f43d25ca55dc6 2023-06-28T11:56:09Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-06-27T15:06:33Z urn:sha1:c0c0beb8e1e549ee46427986c102873cca4debd4 This was super confusing and fragile. Amongst the problems: * Information about exceptional config keys was spread across a number of places, manipulated in ad-hoc ways (conditional Vec appends, etc). * As a consequence, each exceptional table has confusing and unclear semantics. * It doesn't deal well with the way that cargo sometimes enables features for dependency crates even if arti itself wouldn't demand them; this can lead to sub-crates supporting config keys when the tests in arti don't expect them to, causing spurious test failures. Fix this: * Introduce a new, systematic, way of writing information about configuration keys that need some kind of special handling. * Use this new approach in *both* sets of "thorough" config tests. * Be more relaxed about deprecated keys. We don't want to tightly couple this to absence in the supported file, I think. * Understand more clearly the concept of keys of which we don't know, in the current build config, whether the code is expected to accept them. I have tested this locally with: for p in '-p arti' '--workspace'; do for f in '--no-default-features --features=tokio,native-tls' '--all-features' ''; do nailing-cargo test $p $f; done; done 2023-06-26T13:30:54Z Nick Mathewson nickm@torproject.org 2023-06-26T13:30:54Z urn:sha1:0bffdf23a4c9f185b88eb426681bf9ca5f12610f The breaking changes here do not seem to affect us. 2023-06-23T16:49:46Z Nick Mathewson nickm@torproject.org 2023-06-22T19:43:25Z urn:sha1:9e3e683e1b3ea39768ff2a41ad6b0b7172d37a80 The relevant ErrorKinds and macros are now stable. 2023-06-21T13:01:01Z Nick Mathewson nickm@torproject.org 2023-06-14T15:10:35Z urn:sha1:36c411260041f4927745f35aca2cf3fee3351ad4 We don't yet return all of them; this commit adds some todo notes about changes we may need to our ErrorKinds. Part of #736 2023-06-16T11:34:47Z Ian Jackson ijackson@chiark.greenend.org.uk 2023-02-24T14:34:30Z urn:sha1:8d98982bb2f28432d6a9cc8a9c738ee25aad4a2e Rationale as per #756. This is the same name as in the `arti` crate. 2023-06-05T18:47:38Z Nick Mathewson nickm@torproject.org 2023-05-31T19:56:02Z urn:sha1:362a1f8ac1b67ebe66e5683fac8a7995d5e197f4 The actual decoding here is just a placeholder. The important part is that we can get either a (SessionId, StreamId) tuple out of the request, or we treat it as part of an isolation token. This commit has a few TODOs for additional things that we'll need in order to build out our design.