mirrors/arti.git/crates/arti-rpcserver/src, branch arti-v1.4.0 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.4.0 2025-01-30T18:28:11Z Merge branch 'rpc_document_internal_optimism' into 'main' 2025-01-30T18:28:11Z Nick Mathewson nickm@torproject.org 2025-01-30T18:28:11Z urn:sha1:f8d9cedfeecdb9bcdc7b006845c9856fed302f1f rpc: Document what is actually going on with stream optimism. Closes #1583 See merge request tpo/core/arti!2753 proto: Rename (experimental) DataStream functions for ctrl access 2025-01-30T16:11:01Z Nick Mathewson nickm@torproject.org 2025-01-30T15:48:45Z urn:sha1:01197344045835a2e901cf68488332bf3c8ccd56 Since these return a client-specific type, they need a client-specific name before we can stabilize them for RPC. proto: Rename DataStreamCtrl to ClientDataStreamCtrl 2025-01-30T16:11:01Z Nick Mathewson nickm@torproject.org 2025-01-30T15:31:51Z urn:sha1:af6ba7ea0379e2129e1cef1952d193f6783c5bbb The API for this type, and the fact that it implements ClientStreamCtrl unconditionally, means that it is only for client DataStreams. rpc: Document what is actually going on with stream optimism. 2025-01-30T14:55:26Z Nick Mathewson nickm@torproject.org 2025-01-30T14:43:46Z urn:sha1:0feb61e046c08d022a3de3950f39397186414107 In brief: we _do_ correct implement correct optimistic vs nonoptimistic behavior for RPC streams. Only our documentation was wrong. Subsequent commits will fix our documentation more. See #1583. fix: fix typos 2025-01-30T08:39:30Z Dimitris Apostolou dimitris.apostolou@icloud.com 2025-01-30T08:39:30Z urn:sha1:6371829c976f6a5b77d46bf977f369a915f2ced3 rpcserver: Remove a stale TODO. (RpcMgr works.) 2025-01-28T20:28:56Z Nick Mathewson nickm@torproject.org 2025-01-28T20:28:56Z urn:sha1:73a74da5aee953b2ea41ae7daa37cfdd40385dfa rpcserver: Remove stale TODO about authentication 2025-01-28T19:50:22Z Nick Mathewson nickm@torproject.org 2025-01-28T19:50:22Z urn:sha1:46b7be36420cd151aaf6ea32335cfd578604a9a5 (This TODO dates back to the point before we had sessions.) rpcserver: Improve conversion of authentication error. 2025-01-28T19:29:15Z Nick Mathewson nickm@torproject.org 2025-01-28T19:29:15Z urn:sha1:dc29f9cbfc8e03a6ed1c32d6c079fa8b0d48f623 rpc: Remove auth:query. 2025-01-28T19:17:52Z Nick Mathewson nickm@torproject.org 2025-01-28T19:15:24Z urn:sha1:2b2d482c2c6981752480a8e98fa483f6e8a572ce Nothing uses it; its role in negotiation has been replaced by the connect-point design. rpcserver: Remove a stale TODO about ConnectionId. 2025-01-28T19:09:30Z Nick Mathewson nickm@torproject.org 2025-01-28T18:17:45Z urn:sha1:a18a4cb51a837189685477b151c3023e7e7633cb Other parts of the crate no longer look at the .0 field directly.