mirrors/arti.git/crates/arti-rpcserver/src, branch arti-v1.2.5 mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.2.5 2024-06-11T21:02:04Z Several typo fixes from Gabi 2024-06-11T21:02:04Z Nick Mathewson nickm@torproject.org 2024-06-11T20:59:44Z urn:sha1:5a2fb68b19d71b4bd477aa08005f08e05d5438ad Un-indent a block. 2024-06-11T21:02:04Z Nick Mathewson nickm@torproject.org 2024-06-05T16:05:37Z urn:sha1:5654215e51eb514d6b72278706b7a859fc1c54e9 RPC: Use RPC methods instead of the "ClientConnectionTarget" trait. 2024-06-11T21:02:04Z Nick Mathewson nickm@torproject.org 2024-06-04T17:22:30Z urn:sha1:c07455965fd201ec66631e649a10660e5955e47c On its own, this might not seem like a huge improvement, but it will later let us implement these RPC methods for types that can't reasonably implement ClientConnectionTarget. It also serves as a proof of concept that special-method invocation can actually work, so that we can build things like this in cases where introducing a trait isn't practical. Closes #1427 rpc: Make RpcMgr::lookup_object return context along with object. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T14:23:06Z urn:sha1:9267b26bfcf35c5f8594953a75315165849a6828 The context will make it possible to invoke rpc methods. Implement rpc::Context on Connection directly 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T14:00:25Z urn:sha1:aaf12c8970e35ff0f9873cf4c2e27adb2ccaf9e5 This lets us get rid of a now-spurious `RequestContext` wrapper type and an extra layer of indirection; it will also make it easier to treat a Connection _as_ a context, so that we can have a context in the socks-rpc interface code. This patch removes a TODO about "treading carefully" when we make this change. When I added that TODO, I had misremembered some implementation details of the RPC object system. rpc: allow Connection::lookup_object to take &self 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T13:57:40Z urn:sha1:3f7b69dd772c33175f41675e03b304da5c6ec508 This will allow us to implement rpc::Context on Connection directly. rpc: Make the connection type always-Arc. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-05T13:51:04Z urn:sha1:c4c8f533ac057e405b597d1584711fa95cdae604 Use refactored invoke_rpc_method in rpcserver. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-04T16:42:35Z urn:sha1:5f2aaf5fb15e74d7b75ed9a4aa442e2dcb8ef451 rpc: Pass around our rpc::Context in an Arc. 2024-06-10T14:33:01Z Nick Mathewson nickm@torproject.org 2024-06-04T15:31:19Z urn:sha1:acdc2cbe0bc54141e33da320a9551fbcf2e1d7fc Formerly we used a Box. That was okay at first, but now that we want RPC methods to be able to invoke other RPC methods, we don't want the Invocable methods to have to consume the Context. This requires that Context become Sync. RPC: Expose dispatch table from Context 2024-05-16T12:40:06Z Nick Mathewson nickm@torproject.org 2024-05-14T18:52:36Z urn:sha1:533b34a55b268ec73ac032dd8e3d360f2d43b985 We need to do this so that we can actually invoke RPC functions from one another.