mirrors/arti.git/crates/arti-rpcserver/src/session.rs, branch arti-v1.1.4mirror of https://gitlab.torproject.org/tpo/core/arti
http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.42023-04-19T16:38:26ZRPC: Log all internal errors.2023-04-19T16:38:26ZNick Mathewsonnickm@torproject.org2023-04-19T16:35:49Zurn:sha1:7c1f45a514c0c6f5579be939151a3f75db62d731rpcserver: Use with_fn.2023-04-19T16:38:26ZNick Mathewsonnickm@torproject.org2023-04-18T19:55:08Zurn:sha1:f33aefd76c42165302ab0093d207b8e57ca0192frpc: Use Method types to determine type of method outputs, updates.2023-04-19T16:38:26ZNick Mathewsonnickm@torproject.org2023-04-18T17:53:01Zurn:sha1:0503f7bd4bd420df0b06cf9ccdd0b800646108bd
This lets us do much less in our rpc_invoke_fn functions.
rpc: Split Method into DynMethod and Method2023-04-19T16:38:26ZNick Mathewsonnickm@torproject.org2023-04-18T17:04:28Zurn:sha1:7dcfb02c2201c29cb3237f5921a4130e6fcd567a
Now `Method` has an Output and Update associated type, and
`decl_method` can do a little more.
rpc: simplify API by always providing a sink.2023-04-16T12:46:42ZNick Mathewsonnickm@torproject.org2023-04-14T16:35:01Zurn:sha1:5a2c38a1347d0508c59b81ec34732c1ed8fefddd
Previously we have two places where we had to do "make a `Drain` sink
if updates aren't wanted"; now there's only one.
rpc: Ensure well-ordering of responses.2023-04-16T12:46:42ZNick Mathewsonnickm@torproject.org2023-04-14T14:05:56Zurn:sha1:83f5dc48884b66be4c1213f02e403807325cd770
Previously the main loop received updates via a `mpsc::channel`, and
final responses via a `futures::unordered`. This could lead to
final responses being transmitted to the user before the updates
were all flushed.
Now all of the responses are sent to the main loop via the same channel,
and they can't get out-of-sequence.
Closes #817 and (IMO) simplifies the code a bit.
rpc: Move update sink out of context.2023-04-16T12:46:41ZNick Mathewsonnickm@torproject.org2023-04-13T18:14:17Zurn:sha1:3b9fc607637e80bc16876355fbdfa674ce8907f7
Now the update sink is its own boxed object. It is not yet passed
to the invoke functions that want it.
rpc: Change `id=<SYNTAX>` to "no id".2023-04-13T13:03:52ZNick Mathewsonnickm@torproject.org2023-04-13T12:40:36Zurn:sha1:ea77f959fb567b495c1faa0cf3349cbfb86a3b58
Now instead of hoping that buggy clients will detect a magic `id`,
we can simply tell them that they will get no `id` at all. If they
can't handle that case, no major harm is done: the connection will
get closed anyway.
rpc: Require that errors are RpcError.2023-04-13T13:03:52ZNick Mathewsonnickm@torproject.org2023-04-12T20:30:36Zurn:sha1:5041b51498b9854a10f822dd50cc2f0239d586f7
Since we're serializing everything in this format, let's enforce it.
With this change, we can no longer cram arbitrary junk into an
RPC error, so we have to clean up our handling of cancelled requests.
rpc: Improve error reporting for invalid requests2023-04-12T20:21:34ZNick Mathewsonnickm@torproject.org2023-04-12T19:59:47Zurn:sha1:767c91557e6b6bc5429f30b886f8a314df2ddf22
This is a bit big, but it's not that _complicated_.
The idea here is that we use serde's "untagged" enum facility
when parsing our `Request`s, such that if parsing as a `Request`
fails, we parse as an `InvalidRequest` and try to report
what the problem was exactly.
This lets us determine the ID of a request (if it had one),
so we can report that ID in our error message. We can also
recover from a much broader variety of errors.
We now also conform with the spec reporting errors about
completely wrong json, requests without IDs, and so on.