mirror of https://gitlab.torproject.org/tpo/core/arti http://git.dilluti0n.com/mirrors/arti.git/atom?h=arti-v1.1.6 2023-04-19T16:38:26Z 2023-04-19T16:38:26Z Nick Mathewson nickm@torproject.org 2023-04-18T22:43:16Z urn:sha1:accd3d858f9812eba326306014a9543590d93dad Right now, this lets us say whether the method was unrecognized or whether the parameter type was incorrect. We'll use this to enforce correct method names later on. (I have to add another `inventory` here, since the `typetag` maintainer does not want to expose this functionality: see https://github.com/dtolnay/typetag/issues/57#issuecomment-1506106290 ) 2023-04-19T16:38:26Z Nick Mathewson nickm@torproject.org 2023-04-18T17:04:28Z urn:sha1:7dcfb02c2201c29cb3237f5921a4130e6fcd567a Now `Method` has an Output and Update associated type, and `decl_method` can do a little more. 2023-04-13T13:03:52Z Nick Mathewson nickm@torproject.org 2023-04-13T12:40:36Z urn:sha1:ea77f959fb567b495c1faa0cf3349cbfb86a3b58 Now instead of hoping that buggy clients will detect a magic `id`, we can simply tell them that they will get no `id` at all. If they can't handle that case, no major harm is done: the connection will get closed anyway. 2023-04-13T13:03:52Z Nick Mathewson nickm@torproject.org 2023-04-12T20:30:36Z urn:sha1:5041b51498b9854a10f822dd50cc2f0239d586f7 Since we're serializing everything in this format, let's enforce it. With this change, we can no longer cram arbitrary junk into an RPC error, so we have to clean up our handling of cancelled requests. 2023-04-12T20:21:34Z Nick Mathewson nickm@torproject.org 2023-04-12T19:59:47Z urn:sha1:767c91557e6b6bc5429f30b886f8a314df2ddf22 This is a bit big, but it's not that _complicated_. The idea here is that we use serde's "untagged" enum facility when parsing our `Request`s, such that if parsing as a `Request` fails, we parse as an `InvalidRequest` and try to report what the problem was exactly. This lets us determine the ID of a request (if it had one), so we can report that ID in our error message. We can also recover from a much broader variety of errors. We now also conform with the spec reporting errors about completely wrong json, requests without IDs, and so on. 2023-04-12T16:08:53Z Nick Mathewson nickm@torproject.org 2023-04-12T16:08:53Z urn:sha1:6bdfc5740f7244dc05faa5c5a199b94294923f2f Even though json-rpc uses "result" to mean "a successful return value from a method", we can't: Rust's `Result` type is so pervasive that confusion would be inevitable. 2023-04-12T15:51:37Z Nick Mathewson nickm@torproject.org 2023-04-12T15:49:23Z urn:sha1:b2b0a0dd838d1218a4a1a7cb8a184c56064d39ee 2023-04-12T15:25:03Z Nick Mathewson nickm@torproject.org 2023-04-12T15:23:13Z urn:sha1:c5b70224b25c42ed8152527e0308bbbbde2b5624 2023-04-12T11:34:57Z Nick Mathewson nickm@torproject.org 2023-04-11T19:13:19Z urn:sha1:9a5f319a840bbbd906d64803a4992ea1e21b7d1f 2023-04-12T11:34:57Z Nick Mathewson nickm@torproject.org 2023-04-11T12:14:44Z urn:sha1:03937e35b28247dfedbdf0a8153e501b746a620d